188203 – Hardcode some system colors to avoid fingerprinting exposure

Bug 188203 - Hardcode some system colors to avoid fingerprinting exposure

Summary: Hardcode some system colors to avoid fingerprinting exposure

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Timothy Hatcher

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-07-31 12:05 PDT by Timothy Hatcher
Modified:	2020-05-16 20:16 PDT (History)
CC List:	10 users (show)

See Also:	210719

Attachments
Patch (8.81 KB, patch) 2018-07-31 12:07 PDT, Timothy Hatcher	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-sierra (2.32 MB, application/zip) 2018-07-31 13:14 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.84 MB, application/zip) 2018-07-31 13:21 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.05 MB, application/zip) 2018-07-31 15:17 PDT, EWS Watchlist	no flags	Details
Patch (14.64 KB, patch) 2018-07-31 15:19 PDT, Timothy Hatcher	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews100 for mac-sierra (2.38 MB, application/zip) 2018-07-31 16:26 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.81 MB, application/zip) 2018-07-31 16:31 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.18 MB, application/zip) 2018-07-31 16:44 PDT, EWS Watchlist	no flags	Details
Patch (17.86 KB, patch) 2018-07-31 20:55 PDT, Timothy Hatcher	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Timothy Hatcher 2018-07-31 12:05:58 PDT

Don't expose system colors that are based on user appearance preference.

Comment 1 Radar WebKit Bug Importer 2018-07-31 12:06:16 PDT

<rdar://problem/42781630>

Comment 2 Timothy Hatcher 2018-07-31 12:07:45 PDT Comment hidden (obsolete)

Created attachment 346186 [details]
Patch

Comment 3 Tim Horton 2018-07-31 12:38:06 PDT

Comment on attachment 346186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:761
> +            return 0xFF7DADD9;

We can’t get these un-accented from the system?

Comment 4 Timothy Hatcher 2018-07-31 13:02:33 PDT

Comment on attachment 346186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review

>> Source/WebCore/rendering/RenderThemeMac.mm:761
>> +            return 0xFF7DADD9;
> 
> We can’t get these un-accented from the system?

Not that I could find.

Comment 5 EWS Watchlist 2018-07-31 13:14:27 PDT Comment hidden (obsolete)

Comment on attachment 346186 [details]
Patch

Attachment 346186 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8713260

New failing tests:
fast/css/apple-system-control-colors.html
css3/color-filters/color-filter-ignore-semantic.html

Comment 6 EWS Watchlist 2018-07-31 13:14:29 PDT Comment hidden (obsolete)

Created attachment 346194 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 7 EWS Watchlist 2018-07-31 13:21:55 PDT Comment hidden (obsolete)

Comment on attachment 346186 [details]
Patch

Attachment 346186 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8713312

New failing tests:
fast/css/apple-system-control-colors.html
css3/color-filters/color-filter-ignore-semantic.html

Comment 8 EWS Watchlist 2018-07-31 13:21:56 PDT Comment hidden (obsolete)

Created attachment 346196 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 9 EWS Watchlist 2018-07-31 15:17:46 PDT Comment hidden (obsolete)

Comment on attachment 346186 [details]
Patch

Attachment 346186 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8714356

New failing tests:
fast/css/apple-system-control-colors.html
css3/color-filters/color-filter-ignore-semantic.html

Comment 10 EWS Watchlist 2018-07-31 15:17:47 PDT Comment hidden (obsolete)

Created attachment 346209 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 11 Timothy Hatcher 2018-07-31 15:19:08 PDT Comment hidden (obsolete)

Created attachment 346210 [details]
Patch

Comment 12 EWS Watchlist 2018-07-31 16:26:38 PDT Comment hidden (obsolete)

Comment on attachment 346210 [details]
Patch

Attachment 346210 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8715603

New failing tests:
fast/css/apple-system-control-colors.html
fast/css/test-setting-canvas-color.html

Comment 13 EWS Watchlist 2018-07-31 16:26:40 PDT Comment hidden (obsolete)

Created attachment 346218 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 14 EWS Watchlist 2018-07-31 16:31:45 PDT Comment hidden (obsolete)

Comment on attachment 346210 [details]
Patch

Attachment 346210 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8715638

New failing tests:
fast/css/apple-system-control-colors.html
fast/css/test-setting-canvas-color.html

Comment 15 EWS Watchlist 2018-07-31 16:31:47 PDT Comment hidden (obsolete)

Created attachment 346219 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 16 EWS Watchlist 2018-07-31 16:44:31 PDT Comment hidden (obsolete)

Comment on attachment 346210 [details]
Patch

Attachment 346210 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8715558

New failing tests:
fast/css/apple-system-control-colors.html
fast/css/test-setting-canvas-color.html

Comment 17 EWS Watchlist 2018-07-31 16:44:33 PDT Comment hidden (obsolete)

Created attachment 346221 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 18 Timothy Hatcher 2018-07-31 20:55:59 PDT

Created attachment 346254 [details]
Patch

Comment 19 Tim Horton 2018-08-01 11:40:38 PDT

Comment on attachment 346254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346254&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:768
> +                return Color(0x4C1AA9FF, Color::Semantic);

You could neaten this up with the ternary operator but maybe this is easier to read.

Comment 20 WebKit Commit Bot 2018-08-01 12:07:49 PDT

Comment on attachment 346254 [details]
Patch

Clearing flags on attachment: 346254

Committed r234466: <https://trac.webkit.org/changeset/234466>

Comment 21 WebKit Commit Bot 2018-08-01 12:07:51 PDT

All reviewed patches have been landed.  Closing bug.