Bug 188203 – Hardcode some system colors to avoid fingerprinting exposure

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Timothy Hatcher]

Don't expose system colors that are based on user appearance preference.

[Radar WebKit Bug Importer]

<rdar://problem/42781630>

[Timothy Hatcher]

Created attachment 346186 [details]
Patch

[Tim Horton]

Comment on attachment 346186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:761
> +            return 0xFF7DADD9;

We can’t get these un-accented from the system?

[Timothy Hatcher]

Comment on attachment 346186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review

>> Source/WebCore/rendering/RenderThemeMac.mm:761
>> +            return 0xFF7DADD9;
> 
> We can’t get these un-accented from the system?

Not that I could find.

[EWS Watchlist]

Comment on attachment 346186 [details]
Patch

Attachment 346186 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8713260

New failing tests:
fast/css/apple-system-control-colors.html
css3/color-filters/color-filter-ignore-semantic.html

[EWS Watchlist]

Created attachment 346194 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346186 [details]
Patch

Attachment 346186 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8713312

New failing tests:
fast/css/apple-system-control-colors.html
css3/color-filters/color-filter-ignore-semantic.html

[EWS Watchlist]

Created attachment 346196 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346186 [details]
Patch

Attachment 346186 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8714356

New failing tests:
fast/css/apple-system-control-colors.html
css3/color-filters/color-filter-ignore-semantic.html

[EWS Watchlist]

Created attachment 346209 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Created attachment 346210 [details]
Patch

[EWS Watchlist]

Comment on attachment 346210 [details]
Patch

Attachment 346210 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8715603

New failing tests:
fast/css/apple-system-control-colors.html
fast/css/test-setting-canvas-color.html

[EWS Watchlist]

Created attachment 346218 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346210 [details]
Patch

Attachment 346210 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8715638

New failing tests:
fast/css/apple-system-control-colors.html
fast/css/test-setting-canvas-color.html

[EWS Watchlist]

Created attachment 346219 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346210 [details]
Patch

Attachment 346210 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8715558

New failing tests:
fast/css/apple-system-control-colors.html
fast/css/test-setting-canvas-color.html

[EWS Watchlist]

Created attachment 346221 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Created attachment 346254 [details]
Patch

[Tim Horton]

Comment on attachment 346254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346254&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:768
> +                return Color(0x4C1AA9FF, Color::Semantic);

You could neaten this up with the ternary operator but maybe this is easier to read.

[WebKit Commit Bot]

Comment on attachment 346254 [details]
Patch

Clearing flags on attachment: 346254

Committed r234466: <https://trac.webkit.org/changeset/234466>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.