Bug 188194 – [GStreamer] Dynamically adjust blocksize

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Charlie Turner]

[GStreamer] Dynamically adjust blocksize

[Charlie Turner]

Created attachment 346165 [details]
Patch

[Charlie Turner]

Depends on https://bugs.webkit.org/show_bug.cgi?id=188193 landing first.

[Xabier Rodríguez Calvar]

Comment on attachment 346165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346165&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:60
> +    static constexpr int growBlocksizeLimit { 1 };
> +    static constexpr int growBlocksizeCount { 1 };
> +    static constexpr int growBlocksizeFactor { 2 };
> +    static constexpr float reduceBlocksizeLimit { 0.20 };
> +    static constexpr int reduceBlocksizeCount { 2 };
> +    static constexpr float reduceBlocksizeFactor { 0.5 };

These should be prefixed with s_

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:784
> +        m_reduceBlocksizeCount = m_increaseBlocksizeCount = 0;

Please, write this in two lines.

[Charlie Turner]

Created attachment 346374 [details]
Patch

Fix code style violations

[Charlie Turner]

Created attachment 346375 [details]
Patch

Fix code style violations

[WebKit Commit Bot]

Comment on attachment 346375 [details]
Patch

Clearing flags on attachment: 346375

Committed r234498: <https://trac.webkit.org/changeset/234498>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.