Bug 188194 - [GStreamer] Dynamically adjust blocksize
Summary: [GStreamer] Dynamically adjust blocksize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-31 06:50 PDT by Charlie Turner
Modified: 2018-08-02 05:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.94 KB, patch)
2018-07-31 06:53 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2018-08-02 04:38 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch (5.98 KB, patch)
2018-08-02 04:40 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2018-07-31 06:50:57 PDT 
[GStreamer] Dynamically adjust blocksize
Comment 1 Charlie Turner 2018-07-31 06:53:48 PDT 
Created attachment 346165 [details]
Patch
Comment 2 Charlie Turner 2018-07-31 06:54:21 PDT 
Depends on https://bugs.webkit.org/show_bug.cgi?id=188193 landing first.
Comment 3 Xabier Rodríguez Calvar 2018-08-01 00:01:29 PDT 
Comment on attachment 346165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346165&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:60
> +    static constexpr int growBlocksizeLimit { 1 };
> +    static constexpr int growBlocksizeCount { 1 };
> +    static constexpr int growBlocksizeFactor { 2 };
> +    static constexpr float reduceBlocksizeLimit { 0.20 };
> +    static constexpr int reduceBlocksizeCount { 2 };
> +    static constexpr float reduceBlocksizeFactor { 0.5 };

These should be prefixed with s_

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:784
> +        m_reduceBlocksizeCount = m_increaseBlocksizeCount = 0;

Please, write this in two lines.
Comment 4 Charlie Turner 2018-08-02 04:38:32 PDT 
Created attachment 346374 [details]
Patch

Fix code style violations
Comment 5 Charlie Turner 2018-08-02 04:40:26 PDT 
Created attachment 346375 [details]
Patch

Fix code style violations
Comment 6 WebKit Commit Bot 2018-08-02 05:22:00 PDT 
Comment on attachment 346375 [details]
Patch

Clearing flags on attachment: 346375

Committed r234498: <https://trac.webkit.org/changeset/234498>
Comment 7 WebKit Commit Bot 2018-08-02 05:22:02 PDT 
All reviewed patches have been landed.  Closing bug.