Bug 188177 - Add missing CoreGraphics SPI
Summary: Add missing CoreGraphics SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-30 12:18 PDT by Devin Rousso
Modified: 2018-07-30 13:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2018-07-30 12:20 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-07-30 12:18:01 PDT 
From error when building:
> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:319:5: error: use of undeclared identifier 'CGSSetDenyWindowServerConnections'
Comment 1 Devin Rousso 2018-07-30 12:20:27 PDT 
Created attachment 346082 [details]
Patch
Comment 2 Joseph Pecoraro 2018-07-30 12:24:22 PDT 
Comment on attachment 346082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review

r=me

> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305
> +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature.
Comment 3 Devin Rousso 2018-07-30 12:34:18 PDT 
Comment on attachment 346082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review

>> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305
>> +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
> 
> You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature.

I did this to follow it's usage in WebProcessCocoa.mm.  I built it once without it and there was no issue, but I figured it couldn't hurt to match.
Comment 4 WebKit Commit Bot 2018-07-30 13:38:27 PDT 
Comment on attachment 346082 [details]
Patch

Clearing flags on attachment: 346082

Committed r234382: <https://trac.webkit.org/changeset/234382>
Comment 5 WebKit Commit Bot 2018-07-30 13:38:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-30 13:39:22 PDT 
<rdar://problem/42744931>