Bug 188175 - [WinCairo] Search inputs do not show icons
Summary: [WinCairo] Search inputs do not show icons
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-30 10:35 PDT by Stephan Szabo
Modified: 2018-08-06 10:21 PDT (History)
3 users (show)

See Also:


Attachments
Add and load image resources (21.28 KB, patch)
2018-08-03 14:26 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff
Add and load image resources (109.44 KB, patch)
2018-08-03 14:30 PDT, Stephan Szabo
stephan.szabo: review?
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (13.01 MB, application/zip)
2018-08-03 17:11 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-07-30 10:35:06 PDT
The search magnifying glass and <x> erase search term icons are not displayed.
Comment 1 Stephan Szabo 2018-08-03 14:26:58 PDT
Created attachment 346547 [details]
Add and load image resources

resource.h doesn't fit the style guidelines as it's made by visual studio.
Comment 2 Stephan Szabo 2018-08-03 14:30:55 PDT
Created attachment 346550 [details]
Add and load image resources
Comment 3 Build Bot 2018-08-03 14:32:22 PDT
Attachment 346550 [details] did not pass style-queue:


ERROR: Source/WebKit/Platform/win/resource.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Source/WebKit/Platform/win/resource.h:1:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2018-08-03 17:11:00 PDT
Comment on attachment 346550 [details]
Add and load image resources

Attachment 346550 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8755924

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 5 Build Bot 2018-08-03 17:11:11 PDT
Created attachment 346565 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Fujii Hironori 2018-08-05 19:22:12 PDT
You copy the icons and the implentation of loadResourceIntoBuffer from WebKitLegacy.

There is a comment.

https://github.com/WebKit/webkit/blob/c4b88ee56e4f77201ffdcaf6a5988cbc43e199f3/Source/WebKitLegacy/win/WebKitDLL.cpp#L171

> //FIXME: We should consider moving this to a new file for cross-project functionality

It seems that it is the time to fix this. You should have a discussion with AppleWin port forks.