Bug 188175 – [Win] Implement Image::loadPlatformResource

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Stephan Szabo]

The search magnifying glass and <x> erase search term icons are not displayed.

[Stephan Szabo]

Created attachment 346547 [details]
Add and load image resources

resource.h doesn't fit the style guidelines as it's made by visual studio.

[Stephan Szabo]

Created attachment 346550 [details]
Add and load image resources

[EWS Watchlist]

Attachment 346550 [details] did not pass style-queue:


ERROR: Source/WebKit/Platform/win/resource.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Source/WebKit/Platform/win/resource.h:1:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 346550 [details]
Add and load image resources

Attachment 346550 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8755924

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

[EWS Watchlist]

Created attachment 346565 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Fujii Hironori]

You copy the icons and the implentation of loadResourceIntoBuffer from WebKitLegacy.

There is a comment.

https://github.com/WebKit/webkit/blob/c4b88ee56e4f77201ffdcaf6a5988cbc43e199f3/Source/WebKitLegacy/win/WebKitDLL.cpp#L171

> //FIXME: We should consider moving this to a new file for cross-project functionality

It seems that it is the time to fix this. You should have a discussion with AppleWin port forks.

[Stephan Szabo]

Created attachment 417976 [details]
Patch for checking on ews

Initial checking EWS patch for moving resource loading code up into WebCore (so no changelog or the like).

[Fujii Hironori]

Don added a dependency to Bug 232062 for this.
But, I don't like the idea Bug 232062 just for this.
Let's take the original Steph's approach copying images (attachment#346550 [details]).

[Don Olmstead]

Pull request: https://github.com/WebKit/WebKit/pull/1672

[Fujii Hironori]

255715@main (bug#246604) switched WinCairo to use RenderThemeAdwaita instead of RenderThemeWin.
searchCancel, searchCancelPressed and searchMagnifier were used only by RenderThemeWin.

[Fujii Hironori]

We should use icons in https://github.com/WebKit/WebKit/tree/main/Source/WebCore/Resources .

[Fujii Hironori]

Created attachment 464978 [details]
WIP patch

I prefer an approach simply loading icons from a file like media control resources.
I don't want to edit a resource file.

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/11211

[EWS]

Committed 261615@main (77fc48384711): <https://commits.webkit.org/261615@main>

Reviewed commits have been landed. Closing PR #11211 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/106685269>