NEW 188171
[macOS] All WindowServer connections should be closed before denying WindowServer access. 
https://bugs.webkit.org/show_bug.cgi?id=188171
Summary [macOS] All WindowServer connections should be closed before denying WindowSe...
Per Arne Vollan
Reported 2018-07-30 10:15:46 PDT
All WindowServer connections in the WebContent process should be closed before denying access to the WindowServer, otherwise calling CGSSetDenyWindowServerConnections(true) will fail. Currently, there are no open WindowServer connections at this point, but this might change in the future. We should call CGSShutdownServerConnections() before calling CGSSetDenyWindowServerConnections(true) to make sure WindowServer connections are always successfully denied. Thanks to Alex Gaynor at Mozilla (agaynor@mozilla.com) for identifying this issue.
Attachments
Patch (2.31 KB, patch)
2018-07-30 10:19 PDT, Per Arne Vollan 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-07-30 10:19:20 PDT
Created attachment 346066 [details] Patch
Per Arne Vollan
Comment 2 2018-08-03 08:49:17 PDT
Thanks for reviewing!
Ali Juma
Comment 3 2019-09-03 08:14:32 PDT
Just wondering if you're still planning on landing this patch, and if this might prevent error output like the following: FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL
Note You need to log in before you can comment on or make changes to this bug.