Bug 188141 – Shrink GraphicsLayerCA

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Shrink GraphicsLayerCA

[Simon Fraser (smfr)]

Created attachment 346000 [details]
Patch

[EWS Watchlist]

Attachment 346000 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 12 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 346006 [details]
Patch

[EWS Watchlist]

Attachment 346006 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKitLegacy/mac/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 12 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 346006 [details]
Patch

Attachment 346006 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8689257

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
http/tests/security/video-poster-cross-origin-crash2.html

[EWS Watchlist]

Created attachment 346025 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Said Abou-Hallawa]

Comment on attachment 346006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346006&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2790
> +    if (!m_animations)
> +        return;

I would suggest also hiding this lazy initialization by an inline function like:

bool isAnimationAvailable() { return m_animations; }

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2864
> +void GraphicsLayerCA::ensureLayerAnimations()
> +{
> +    if (!m_animations)
> +        m_animations = std::make_unique<LayerAnimations>();
> +}

I would suggest writing this function like this:

LayerAnimations& GraphicsLayerCA::ensureLayerAnimations()
{
    if (!m_animations)
        m_animations = std::make_unique<LayerAnimations>();
    return *m_animations;
}

And replace all the instances of m_animations with ensureLayerAnimations(). This will make it clear that m_animations should not be accessed directly since it can be nullptr. But calling ensureLayerAnimations() is always safe to use.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/234393/webkit

[Radar WebKit Bug Importer]

<rdar://problem/42750761>