Bug 188140 - [Cocoa] Update more WebCore Objective-C code to be ARC compatible
Summary: [Cocoa] Update more WebCore Objective-C code to be ARC compatible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-28 14:15 PDT by Darin Adler
Modified: 2018-07-29 14:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (95.69 KB, patch)
2018-07-28 15:10 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (97.19 KB, patch)
2018-07-28 22:21 PDT, Darin Adler 		sam: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.95 MB, application/zip)
2018-07-29 02:03 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-07-28 14:15:55 PDT 
[Cocoa] Update more WebCore Objective-C code to be ARC compatible
Comment 1 Darin Adler 2018-07-28 15:10:07 PDT 
Created attachment 346001 [details]
Patch
Comment 2 Darin Adler 2018-07-28 22:21:03 PDT 
Created attachment 346012 [details]
Patch
Comment 3 EWS Watchlist 2018-07-29 02:03:12 PDT 
Comment on attachment 346012 [details]
Patch

Attachment 346012 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8689239

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 4 EWS Watchlist 2018-07-29 02:03:24 PDT 
Created attachment 346022 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Darin Adler 2018-07-29 10:55:38 PDT 
Anyone got a theory about why that Windows test failed? Tempting to dismiss it as unrelated to this patch but I don’t know.
Comment 6 Yusuke Suzuki 2018-07-29 11:18:00 PDT 
(In reply to Darin Adler from comment #5)
> Anyone got a theory about why that Windows test failed? Tempting to dismiss
> it as unrelated to this patch but I don’t know.

This http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html test is flaky these days. Even Intl in JS changes report this test is failing[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=167991
Comment 7 Darin Adler 2018-07-29 12:47:48 PDT 
OK, so: passing tests, looking for a reviewer.
Comment 8 Sam Weinig 2018-07-29 13:45:42 PDT 
Comment on attachment 346012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346012&action=review

> Source/WebCore/ChangeLog:59
> +        (WebCore::DictionaryLookup::rangeForSelection): Return a typle rather

Typo. You mean tuple I am pretty sure.
Comment 9 Darin Adler 2018-07-29 14:45:50 PDT 
Committed r234348: <https://trac.webkit.org/changeset/234348>
Comment 10 Radar WebKit Bug Importer 2018-07-29 14:47:15 PDT 
<rdar://problem/42713399>