From PlatformCookieJar.h: // FIXME: These should probably be NetworkStorageSession member functions.
Created attachment 345998 [details] Patch
Attachment 345998 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346015 [details] Patch
Attachment 346015 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346023 [details] Patch
Attachment 346023 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:48: "WebKitSystemInterface/WebKitSystemInterface.h" already included at Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:38 [build/include] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346026 [details] Patch
Attachment 346026 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:48: "WebKitSystemInterface/WebKitSystemInterface.h" already included at Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:38 [build/include] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346030 [details] Patch
This LGTM but maybe someone familiar with the networking code should review it.
Comment on attachment 346030 [details] Patch r=me, too. I wonder if https://bugs.webkit.org/show_bug.cgi?id=161106 would be easier after this.
(In reply to Alex Christensen from comment #11) > Comment on attachment 346030 [details] > Patch > > r=me, too. > I wonder if https://bugs.webkit.org/show_bug.cgi?id=161106 would be easier > after this. @Alex: Rob is in vacations so I guess we can land this patch now, especially if that helps you for bug 161106.
Hi guys, I am officially on vacations but only flying away next week, so feel free to CC me on bugs. Bug 161106 may be more something for Alex as I am still pretty new to cookie related code.
Comment on attachment 346030 [details] Patch Clearing flags on attachment: 346030 Committed r234376: <https://trac.webkit.org/changeset/234376>
All reviewed patches have been landed. Closing bug.
<rdar://problem/42742897>