RESOLVED FIXED 188134
[ews-build] loadConfig should ensure that the triggers are valid 
https://bugs.webkit.org/show_bug.cgi?id=188134
Summary [ews-build] loadConfig should ensure that the triggers are valid
Aakash Jain
Reported 2018-07-27 18:23:56 PDT
loadConfig should ensure that the triggers are valid, so as to prevent any errors in triggers. Two common cases of error in triggers are: 1) unused trigger in 'triggers' section of config.json 2) builder referencing non-existing trigger Unit-tests should fail when above error exist in config.json Also see: <rdar://problem/35892616> for related issue.
Attachments
Proposed patch (8.84 KB, patch)
2018-07-27 18:28 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (13.03 MB, application/zip)
2018-07-28 00:36 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-07-27 18:28:11 PDT
Created attachment 345984 [details] Proposed patch
EWS Watchlist
Comment 2 2018-07-28 00:36:31 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 3 2018-07-28 00:36:43 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 4 2018-07-30 16:22:29 PDT
Comment on attachment 345984 [details] Proposed patch Clearing flags on attachment: 345984 Committed r234395: <https://trac.webkit.org/changeset/234395>
WebKit Commit Bot
Comment 5 2018-07-30 16:22:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-07-30 16:24:10 PDT
<rdar://problem/42751331>
Note You need to log in before you can comment on or make changes to this bug.