Bug 188134 - [ews-build] loadConfig should ensure that the triggers are valid
Summary: [ews-build] loadConfig should ensure that the triggers are valid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-27 18:23 PDT by Aakash Jain
Modified: 2018-07-30 16:24 PDT (History)
7 users (show)

See Also:


Attachments
Proposed patch (8.84 KB, patch)
2018-07-27 18:28 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (13.03 MB, application/zip)
2018-07-28 00:36 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-07-27 18:23:56 PDT
loadConfig should ensure that the triggers are valid, so as to prevent any errors in triggers. Two common cases of error in triggers are:
1) unused trigger in 'triggers' section of config.json
2) builder referencing non-existing trigger

Unit-tests should fail when above error exist in config.json

Also see: <rdar://problem/35892616> for related issue.
Comment 1 Aakash Jain 2018-07-27 18:28:11 PDT
Created attachment 345984 [details]
Proposed patch
Comment 2 EWS Watchlist 2018-07-28 00:36:31 PDT Comment hidden (obsolete)
Comment 3 EWS Watchlist 2018-07-28 00:36:43 PDT Comment hidden (obsolete)
Comment 4 WebKit Commit Bot 2018-07-30 16:22:29 PDT
Comment on attachment 345984 [details]
Proposed patch

Clearing flags on attachment: 345984

Committed r234395: <https://trac.webkit.org/changeset/234395>
Comment 5 WebKit Commit Bot 2018-07-30 16:22:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-30 16:24:10 PDT
<rdar://problem/42751331>