Bug 188126 – Web Inspector: Dark Mode: SourceCodeTextEditor error/warning text widget is too light

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 345953 [details]
[Image] SourceCodeTextEditor error message widget

Summary:
SourceCodeTextEditor error/warning text widget is too light.

This affects the expanded widget only, the inline message text is styled correctly.

[Radar WebKit Bug Importer]

<rdar://problem/42674963>

[Nikita Vasilyev]

Created attachment 346562 [details]
Patch

[Nikita Vasilyev]

Created attachment 346563 [details]
[Image] With patch applied

[Nikita Vasilyev]

Comment on attachment 346562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346562&action=review

> Source/WebInspectorUI/UserInterface/Views/DarkMode.css:1048
>      .source-code.text-editor > .CodeMirror .issue-widget.inline.error {

We can't remove the selector for the inline widget. Removing this line would cause the light mode rule to have higher priority.

Alternatively, I could have used !important:

    .source-code.text-editor > .CodeMirror .issue-widget.error {
        background-color: var(--error-background-color) !important;
    }

But I try to avoid it whenever possible.

[Matt Baker]

Comment on attachment 346562 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 346562 [details]
Patch

Clearing flags on attachment: 346562

Committed r234736: <https://trac.webkit.org/changeset/234736>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.