Bug 188115 - [GTK] API test /webkit/WebKitWebInspectorServer/test-page-list is flaky
Summary: [GTK] API test /webkit/WebKitWebInspectorServer/test-page-list is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Mac Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-27 12:33 PDT by Michael Catanzaro
Modified: 2020-07-15 01:52 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.70 KB, patch)
2020-07-14 06:08 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-07-27 12:33:03 PDT
API test /webkit/WebKitWebInspectorServer/test-page-list is flaky:

TEST: ./Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer...
  /webkit/WebKitWebInspectorServer/test-page-list:                    FAIL
ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:150:void testInspectorServerPageList(InspectorServerTest*, gconstpointer): assertion failed (valueString.get() == "http://127.0.0.1:2999/"): ("about:blank" == "http://127.0.0.1:2999/")
Comment 1 Carlos Garcia Campos 2020-07-14 06:05:31 PDT
The test is still trying to connect to DBus, but we no longer use DBus. Let's fix the test and see if its still flaky.
Comment 2 Carlos Garcia Campos 2020-07-14 06:08:24 PDT
Created attachment 404228 [details]
Patch
Comment 3 Carlos Garcia Campos 2020-07-15 01:52:39 PDT
Committed r264390: <https://trac.webkit.org/changeset/264390>