Bug 188113 - [GTK] API test /webkit/WebKitWebsiteData/cache is flaky
Summary: [GTK] API test /webkit/WebKitWebsiteData/cache is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-27 12:26 PDT by Michael Catanzaro
Modified: 2022-01-20 19:59 PST (History)
3 users (show)

See Also:

Attachments
[fast-cq] Patch updating expectations (1.48 KB, patch)
2022-01-20 19:56 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-07-27 12:26:53 PDT 
API test /webkit/WebKitWebsiteData/cache is flaky:

TEST: ./Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestWebsiteData...
  /webkit/WebKitWebsiteData/configuration:                            PASS
  /webkit/WebKitWebsiteData/ephemeral:                                PASS
  /webkit/WebKitWebsiteData/cache:                                    FAIL
ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:285:void testWebsiteDataCache(WebsiteDataTest*, gconstpointer): assertion failed (webkit_website_data_get_types(data) == cacheTypes): (1 == 3)
  /webkit/WebKitWebsiteData/storage:                                  PASS
  /webkit/WebKitWebsiteData/databases:                                PASS
  /webkit/WebKitWebsiteData/appcache:                                 PASS
  /webkit/WebKitWebsiteData/cookies:                                  PASS
Comment 1 Claudio Saavedra 2019-08-08 07:49:04 PDT 
I think this test fails because the 1 second wait in the function is not always enough for the data to be saved. I tried locally a few runs with a higher wait (2 seconds, I think) and I couldn't get it to fail.
Comment 2 Lauro Moura 2022-01-20 19:56:44 PST 
Created attachment 449633 [details]
[fast-cq] Patch updating expectations

It has been consistently passing in GTK/WPE for a long time. Sometimes fails consistently, but due to regressions.
Comment 3 EWS 2022-01-20 19:59:31 PST 
Committed r288349 (246255@main): <https://commits.webkit.org/246255@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449633 [details].