Bug 188097 - Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable()
Summary: Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 187284
  Show dependency tree / graph
 
Reported: 2018-07-27 10:45 PDT by Chris Dumez
Modified: 2018-07-27 15:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (18.83 KB, patch)
2018-07-27 13:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (18.90 KB, patch)
2018-07-27 13:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-07-27 10:45:17 PDT 
Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable(). RealtimeMediaSource::audioSamplesAvailable() is called on a background thread but iterates over observers that may get destroyed concurrently on the main thread.
Comment 1 Chris Dumez 2018-07-27 11:05:10 PDT 
<rdar://problem/42558823>
Comment 2 Chris Dumez 2018-07-27 13:02:03 PDT 
Created attachment 345943 [details]
Patch
Comment 3 Chris Dumez 2018-07-27 13:53:37 PDT 
Created attachment 345950 [details]
Patch
Comment 4 WebKit Commit Bot 2018-07-27 15:33:58 PDT 
Comment on attachment 345950 [details]
Patch

Clearing flags on attachment: 345950

Committed r234334: <https://trac.webkit.org/changeset/234334>
Comment 5 WebKit Commit Bot 2018-07-27 15:34:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-27 15:34:34 PDT 
<rdar://problem/42677538>