Bug 188093 – [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Garcia Campos]

Use the new API.

[Carlos Garcia Campos]

Created attachment 345908 [details]
WIP

[Zan Dobersek]

Comment on attachment 345908 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=345908&action=review

> Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:306
> +    // FIXME: we don't have a way to get hardware key code in WPE.

This could be retrieved with a xkb_keymap object? If so, FIXME should note that.

[Carlos Garcia Campos]

(In reply to Zan Dobersek from comment #2)
> Comment on attachment 345908 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345908&action=review
> 
> > Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:306
> > +    // FIXME: we don't have a way to get hardware key code in WPE.
> 
> This could be retrieved with a xkb_keymap object? If so, FIXME should note
> that.

I don't know, I'll investigate.

[Carlos Garcia Campos]

(In reply to Carlos Garcia Campos from comment #3)
> (In reply to Zan Dobersek from comment #2)
> > Comment on attachment 345908 [details]
> > WIP
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=345908&action=review
> > 
> > > Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:306
> > > +    // FIXME: we don't have a way to get hardware key code in WPE.
> > 
> > This could be retrieved with a xkb_keymap object? If so, FIXME should note
> > that.
> 
> I don't know, I'll investigate.

It requires https://github.com/WebPlatformForEmbedded/WPEBackend/pull/24 I'll keep the FIXME anyway, since the patch to use the key mapper will introduce more changes.

[Carlos Garcia Campos]

Created attachment 346463 [details]
Patch

[Zan Dobersek]

Comment on attachment 346463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346463&action=review

> Source/WebKit/ChangeLog:9
> +        
> +

Extra white space.

> Tools/ChangeLog:9
> +        
> +

Extra white space.

> Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:273
> +    // FIXME: we don't have a way to get hardware key code in WPE.

Is this now not retrievable from wpe_input_xkb_context_get_entries_for_key_code()? Or am I mixing things up?

[Carlos Garcia Campos]

(In reply to Zan Dobersek from comment #6)
> Comment on attachment 346463 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346463&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        
> > +
> 
> Extra white space.
> 
> > Tools/ChangeLog:9
> > +        
> > +
> 
> Extra white space.
> 
> > Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:273
> > +    // FIXME: we don't have a way to get hardware key code in WPE.
> 
> Is this now not retrievable from
> wpe_input_xkb_context_get_entries_for_key_code()? Or am I mixing things up?

Yes, this is part of a follow up patch in bug #188216

[Carlos Garcia Campos]

Committed r234540: <https://trac.webkit.org/changeset/234540>