Bug 188086 – Don't include WebPageProxy.h just for UndoOrRedo

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Don't include WebPageProxy.h just for UndoOrRedo

[Alex Christensen]

Created attachment 345890 [details]
Patch

[EWS Watchlist]

Attachment 345890 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/PageClient.h:46:  _WKRemoteObjectRegistry is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 345890 [details]
Patch

Attachment 345890 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8670989

New failing tests:
http/tests/security/local-video-source-from-remote.html

[EWS Watchlist]

Created attachment 345909 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Alex Christensen]

Created attachment 345920 [details]
Patch

[EWS Watchlist]

Attachment 345920 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/PageClient.h:46:  _WKRemoteObjectRegistry is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 345924 [details]
Patch

[EWS Watchlist]

Attachment 345924 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/PageClient.h:46:  _WKRemoteObjectRegistry is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 345929 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[EWS Watchlist]

Attachment 345929 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/PageClient.h:46:  _WKRemoteObjectRegistry is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 345947 [details]
Patch

[EWS Watchlist]

Attachment 345947 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/PageClient.h:46:  _WKRemoteObjectRegistry is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 345947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345947&action=review

> Source/WebKit/Shared/UndoOrRedo.h:32
> +enum class UndoOrRedo { Undo, Redo };

: uint8_t?

[Alex Christensen]

Comment on attachment 345947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345947&action=review

>> Source/WebKit/Shared/UndoOrRedo.h:32
>> +enum class UndoOrRedo { Undo, Redo };
> 
> : uint8_t?

We could, but it's not stored anywhere.

[Saam Barati]

Comment on attachment 345947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345947&action=review

>>> Source/WebKit/Shared/UndoOrRedo.h:32
>>> +enum class UndoOrRedo { Undo, Redo };
>> 
>> : uint8_t?
> 
> We could, but it's not stored anywhere.

not yet :)

[Alex Christensen]

https://trac.webkit.org/changeset/234333/webkit

[Radar WebKit Bug Importer]

<rdar://problem/42677532>