Bug 188082 - Web Inspector: REGRESSION (r233824): execution highlight range missing/incorrect in pretty printed code
Summary: Web Inspector: REGRESSION (r233824): execution highlight range missing/incorr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P1 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-26 15:27 PDT by Matt Baker
Modified: 2018-10-15 14:21 PDT (History)
4 users (show)

See Also:

Attachments
[Webarchive] reduced test case (2.49 KB, application/x-webarchive)
2018-07-26 15:27 PDT, Matt Baker 		no flags Details
Patch (3.34 KB, patch)
2018-10-12 17:56 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-07-26 15:27:21 PDT 
Created attachment 345881 [details]
[Webarchive] reduced test case

Summary:
Execution highlight range missing/incorrect in pretty printed code.

Regressed in http://trac.webkit.org/changeset/233824.

Steps to Reproduce:
1. Inspect the attached webarchive
2. View chained-property-stepping-min.js in Debugger tab
3. Enable pretty printing
4. Set breakpoint at line 13
5. Reload page
  => Paused in debugger

Expected:
  => Expression-level execution highlight: |return 42|

Actual:
  => Expression-level execution highlight missing (whole line is highlighted)
Comment 1 Radar WebKit Bug Importer 2018-07-26 15:27:50 PDT 
<rdar://problem/42640580>
Comment 2 Matt Baker 2018-10-12 17:56:38 PDT 
Created attachment 352246 [details]
Patch
Comment 3 Joseph Pecoraro 2018-10-15 13:55:59 PDT 
Comment on attachment 352246 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-10-15 14:21:25 PDT 
Comment on attachment 352246 [details]
Patch

Clearing flags on attachment: 352246

Committed r237145: <https://trac.webkit.org/changeset/237145>
Comment 5 WebKit Commit Bot 2018-10-15 14:21:27 PDT 
All reviewed patches have been landed.  Closing bug.