Bug 188079 - [ews-build] Add build step to run API Tests
Summary: [ews-build] Add build step to run API Tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-26 14:54 PDT by Aakash Jain
Modified: 2018-07-26 15:54 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (11.42 KB, patch)
2018-07-26 15:03 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Proposed patch (12.10 KB, patch)
2018-07-26 15:07 PDT, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-07-26 14:54:59 PDT
We should have an EWS for API tests. For that we should have a build step to run API tests.
Comment 1 Aakash Jain 2018-07-26 15:03:25 PDT Comment hidden (obsolete)
Comment 2 Aakash Jain 2018-07-26 15:07:14 PDT
Created attachment 345876 [details]
Proposed patch

Sample run: http://ews-build.webkit-uat.org/#/builders/18/builds/26
Comment 3 EWS Watchlist 2018-07-26 15:08:31 PDT Comment hidden (obsolete)
Comment 4 Lucas Forschler 2018-07-26 15:18:33 PDT
Comment on attachment 345876 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345876&action=review

r=me as is, with a nit, and something to think about for future patches.

> Tools/BuildSlaveSupport/ews-build/steps.py:378
> +    descriptionDone = ['api-tests']

api tests completed?

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:871
> +        self.setProperty('fullPlatform', 'mac-sierra')

some pondering...  mac-highsierra is released, and Mojave is in beta. Mac-sierra will be the next platform to fall off the supported list. 
I don't think it really matters for unit tests, unless we run into a problem where the fullPlatform is not in a supported list somewhere...
Do we want to be in the business of updating these periodically as they fall off, or just be ok with the fact that it will soon reference really stale releases?

If we try to keep them relevant, then we should be using mac-mojave everywhere, which would be a larger change in many files.
Comment 5 Aakash Jain 2018-07-26 15:53:15 PDT
Committed r234280: <https://trac.webkit.org/changeset/234280>
Comment 6 Radar WebKit Bug Importer 2018-07-26 15:54:17 PDT
<rdar://problem/42641478>