Bug 188075 - REGRESSION(r234181): These are not needed right now (Requested by thorton on #webkit).
Summary: REGRESSION(r234181): These are not needed right now (Requested by thorton on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 187979 187985
  Show dependency tree / graph
 
Reported: 2018-07-26 13:56 PDT by WebKit Commit Bot
Modified: 2018-07-28 21:54 PDT (History)
4 users (show)

See Also:

Attachments
ROLLOUT of r234181 (12.47 KB, patch)
2018-07-26 13:56 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
Patch (13.70 KB, patch)
2018-07-28 21:54 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2018-07-26 13:56:00 PDT 
https://trac.webkit.org/changeset/234181 broke the build:
These are not needed right now (Requested by thorton on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2018-07-26 13:56:12 PDT 
Created attachment 345864 [details]
ROLLOUT of r234181

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2018-07-26 14:11:18 PDT 
Comment on attachment 345864 [details]
ROLLOUT of r234181

Clearing flags on attachment: 345864

Committed r234272: <https://trac.webkit.org/changeset/234272>
Comment 3 WebKit Commit Bot 2018-07-26 14:11:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-07-26 14:12:19 PDT 
<rdar://problem/42637563>
Comment 5 Andy Estes 2018-07-28 21:54:12 PDT 
Reopening to attach new patch.
Comment 6 Andy Estes 2018-07-28 21:54:13 PDT 
Created attachment 346009 [details]
Patch
Comment 7 Andy Estes 2018-07-28 21:54:46 PDT 
Oops, webkit-patch posted this to the wrong bug. Weird.