RESOLVED FIXED 188067
Use the Page's appearance when converting pasteboard attributed strings 
https://bugs.webkit.org/show_bug.cgi?id=188067
Summary Use the Page's appearance when converting pasteboard attributed strings
Timothy Hatcher
Reported 2018-07-26 11:44:44 PDT
The color conversion of NSAttributedString rely on the appearance. We should use the page's appearance in this case.
Attachments
Patch (4.11 KB, patch)
2018-07-26 11:48 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-26 11:45:11 PDT
<rdar://problem/42632246>
Timothy Hatcher
Comment 2 2018-07-26 11:48:53 PDT
Created attachment 345856 [details] Patch
Megan Gardner
Comment 3 2018-07-26 11:54:35 PDT
Comment on attachment 345856 [details] Patch r=me, unofficial
Wenson Hsieh
Comment 4 2018-07-26 12:39:13 PDT
Comment on attachment 345856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345856&action=review Is this testable in any way? > Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:128 > + auto* page = frame.page(); I was wondering if there's ever a case where page could be null, but it looks like we're okay here because createFragmentAndAddResources will bail if !frame.page().
Timothy Hatcher
Comment 5 2018-07-26 13:02:12 PDT
(In reply to Wenson Hsieh from comment #4) > Comment on attachment 345856 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345856&action=review > > Is this testable in any way? Not currently. I am working on dark mode testing support in general and have many tests to add.
WebKit Commit Bot
Comment 6 2018-07-26 13:30:14 PDT
Comment on attachment 345856 [details] Patch Clearing flags on attachment: 345856 Committed r234270: <https://trac.webkit.org/changeset/234270>
WebKit Commit Bot
Comment 7 2018-07-26 13:30:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.