Bug 188066 - Add Aaron Chu as a committer to contributors.json
Summary: Add Aaron Chu as a committer to contributors.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aaron Chu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-26 11:28 PDT by Aaron Chu
Modified: 2021-11-01 12:49 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2018-07-26 11:39 PDT, Aaron Chu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Chu 2018-07-26 11:28:33 PDT
Add Aaron Chu as a committer to contributors.json
Comment 1 Aaron Chu 2018-07-26 11:39:12 PDT
Created attachment 345855 [details]
Patch
Comment 2 EWS Watchlist 2018-07-26 11:42:30 PDT
Attachment 345855 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Aaron Chu 2018-07-26 16:19:49 PDT
Committed r234282: <https://trac.webkit.org/changeset/234282>
Comment 4 Radar WebKit Bug Importer 2018-07-26 16:20:25 PDT
<rdar://problem/42642325>
Comment 5 Alex Christensen 2021-11-01 12:49:13 PDT
Comment on attachment 345855 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.