Bug 18806 - Compilation breaks with arm-linux-g++ 3.4.6
Summary: Compilation breaks with arm-linux-g++ 3.4.6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-29 22:46 PDT by Sriram Neelakandan
Modified: 2008-05-23 03:20 PDT (History)
1 user (show)

See Also:

Attachments
Compilation fix (531 bytes, patch)
2008-04-29 22:56 PDT, Sriram Neelakandan 		no flags Details | Formatted Diff | Diff
Compilation fix with arm 3.x compiler (889 bytes, patch)
2008-05-07 23:23 PDT, Sriram Neelakandan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sriram Neelakandan 2008-04-29 22:46:30 PDT 
arm compilation breaks with gcc 3.4.6 compiler. 
Revision : r32652

arm-linux-g++  compiling file ../WebKit/gtk/webkit/webkitwebframe.cpp

In file included from ../JavaScriptCore/kjs/lookup.h:28,
                 from ../WebCore/bindings/js/kjs_binding.h:26,
                 from ../WebCore/bindings/js/JSDOMWindowBase.h:25,
                 from ./DerivedSources/JSDOMWindow.h:24,
                 from ../WebKit/gtk/webkit/webkitwebframe.cpp:38:
../JavaScriptCore/kjs/JSGlobalObject.h: In constructor `KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData()':
../JavaScriptCore/kjs/JSGlobalObject.h:82: error: no matching function for call to `KJS::PerThreadData::PerThreadData()'
../JavaScriptCore/kjs/ExecState.h:50: note: candidates are: KJS::PerThreadData::PerThreadData(const KJS::PerThreadData&)

The default constructor in 3.x series takes a structure reference always.

If we add an explicit default constructor, the compilation goes through fine
Comment 1 Sriram Neelakandan 2008-04-29 22:56:06 PDT 
Created attachment 20898 [details]
Compilation fix

Default constructor has been declared explicitly to avoid the compilation breakage
Comment 2 Sriram Neelakandan 2008-05-07 23:23:37 PDT 
Created attachment 21009 [details]
Compilation fix with arm 3.x compiler

added changelog & updated to latest revision
Comment 3 Alp Toker 2008-05-23 03:20:51 PDT 
Comment on attachment 21009 [details]
Compilation fix with arm 3.x compiler

Issue fixed already.