Bug 188058 – [WPE] webanimations/partly-accelerated-transition-by-removing-property.html is failing since added in r234250 "[Web Animations] REGRESSION: transition added immediately after element creation doesn't work"

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Miguel Gomez]

webanimations/partly-accelerated-transition-by-removing-property.html [ Failure ]

The test fails cause the expectation is empty: it's a dump of the layer tree and there are no layers. But on WPE there are layers. This is the diff

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/webanimations/partly-accelerated-transition-by-removing-property-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/webanimations/partly-accelerated-transition-by-removing-property-actual.txt
@@ -1 +1,11 @@
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (children 1
+    (GraphicsLayer
+      (bounds 800.00 600.00)
+      (contentsOpaque 1)
+    )
+  )
+)

I suspect this is just because WPE is always in accelerated compositing mode, and the test expects that removing the animation will cause webkit to leave AC mode. I'll check this and update the expectations if that's the case.

[Miguel Gomez]

Created attachment 346148 [details]
Patch

[Miguel Gomez]

Created attachment 346149 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 346149 [details]
Patch

Clearing flags on attachment: 346149

Committed r234421: <https://trac.webkit.org/changeset/234421>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.