Bug 188058 - [WPE] webanimations/partly-accelerated-transition-by-removing-property.html is failing since added in r234250 "[Web Animations] REGRESSION: transition added immediately after element creation doesn't work"
Summary: [WPE] webanimations/partly-accelerated-transition-by-removing-property.html i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-26 08:08 PDT by Miguel Gomez
Modified: 2018-07-31 03:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2018-07-31 02:59 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (2.30 KB, patch)
2018-07-31 02:59 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-07-26 08:08:09 PDT
webanimations/partly-accelerated-transition-by-removing-property.html [ Failure ]

The test fails cause the expectation is empty: it's a dump of the layer tree and there are no layers. But on WPE there are layers. This is the diff

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/webanimations/partly-accelerated-transition-by-removing-property-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/webanimations/partly-accelerated-transition-by-removing-property-actual.txt
@@ -1 +1,11 @@
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (children 1
+    (GraphicsLayer
+      (bounds 800.00 600.00)
+      (contentsOpaque 1)
+    )
+  )
+)

I suspect this is just because WPE is always in accelerated compositing mode, and the test expects that removing the animation will cause webkit to leave AC mode. I'll check this and update the expectations if that's the case.
Comment 1 Miguel Gomez 2018-07-31 02:59:02 PDT
Created attachment 346148 [details]
Patch
Comment 2 Miguel Gomez 2018-07-31 02:59:35 PDT
Created attachment 346149 [details]
Patch
Comment 3 WebKit Commit Bot 2018-07-31 03:39:44 PDT
Comment on attachment 346149 [details]
Patch

Clearing flags on attachment: 346149

Committed r234421: <https://trac.webkit.org/changeset/234421>
Comment 4 WebKit Commit Bot 2018-07-31 03:39:45 PDT
All reviewed patches have been landed.  Closing bug.