Bug 188045 - [WebIDL] Element's scrollLeft and scrollTop should be unrestricted double
Summary: [WebIDL] Element's scrollLeft and scrollTop should be unrestricted double
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 5991
  Show dependency tree / graph
 
Reported: 2018-07-26 06:53 PDT by Frédéric Wang (:fredw)
Modified: 2018-08-31 01:36 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.46 KB, patch)
2018-07-26 08:17 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-07-26 06:53:29 PDT 
Follow-up of bug 161610:

(In reply to Simon Fraser (smfr) from comment #3)
> > > Source/WebCore/dom/Element.idl:75
> > > -    attribute long scrollLeft;
> > > -    attribute long scrollTop;
> > > +    attribute long scrollLeft; // FIXME: should be unrestricted double
> > > +    attribute long scrollTop; // FIXME: should be unrestricted double
> > 
> > Seems relatively straightforward to fix this.
> 
> I didn't want to make a web-facing change here in the same patch.
Comment 1 Frédéric Wang (:fredw) 2018-07-26 08:17:38 PDT 
Created attachment 345845 [details]
Patch

Just some quick patch for testing purpose...
Comment 2 Frédéric Wang (:fredw) 2018-08-31 01:36:33 PDT 
> (In reply to Simon Fraser (smfr) from comment #3)
> > > > Source/WebCore/dom/Element.idl:75
> > > > -    attribute long scrollLeft;
> > > > -    attribute long scrollTop;
> > > > +    attribute long scrollLeft; // FIXME: should be unrestricted double
> > > > +    attribute long scrollTop; // FIXME: should be unrestricted double
> > > 
> > > Seems relatively straightforward to fix this.
> > 
> > I didn't want to make a web-facing change here in the same patch.

@Simon: Any idea how this change could be visible to the user? And hence whether we can can/should test it?

I tried using values larger than the max long or non-integer values, but scrollable overflow elements/frames seem to have a limited size and to round up scroll position, so that does not seem easy.