Bug 188035 - Manually activate the selection assistant for Tap and a Half gestures
Summary: Manually activate the selection assistant for Tap and a Half gestures
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-25 21:01 PDT by Megan Gardner
Modified: 2018-07-26 12:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2018-07-25 21:04 PDT, Megan Gardner 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-07-25 21:01:50 PDT 
Manually activate the selection assistant for Tap and a Half gestures
Comment 1 Megan Gardner 2018-07-25 21:04:53 PDT 
Created attachment 345816 [details]
Patch
Comment 2 Megan Gardner 2018-07-25 21:06:17 PDT 
<rdar://problem/42595472>
Comment 3 Tim Horton 2018-07-25 21:39:27 PDT 
Comment on attachment 345816 [details]
Patch

Eww?

Also, test?
Comment 4 Simon Fraser (smfr) 2018-07-25 21:48:29 PDT 
Comment on attachment 345816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345816&action=review

> Source/WebKit/ChangeLog:11
> +        is starting. This does not interfear with activation for other gestures, and it ensures that

interfere

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2731
> +    // <rdar://problem/42610532> Find a better way to make sure that the selection assistant is activated for tap and a half gestures

Maybe don't include the radar title.
Comment 5 Tim Horton 2018-07-25 21:57:52 PDT 
Comment on attachment 345816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345816&action=review

>> Source/WebKit/ChangeLog:11
>> +        is starting. This does not interfear with activation for other gestures, and it ensures that
> 
> interfere

You don’t fear it?

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2731
>> +    // <rdar://problem/42610532> Find a better way to make sure that the selection assistant is activated for tap and a half gestures
> 
> Maybe don't include the radar title.

Yeah, this can be one line even, with the radar in parens after fixme.
Comment 6 Megan Gardner 2018-07-26 12:05:20 PDT 
Decided to go with a change in UIKit instead, as it was less hacky.