WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
188031
[ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
https://bugs.webkit.org/show_bug.cgi?id=188031
Summary
[ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
Aakash Jain
Reported
2018-07-25 17:09:24 PDT
Builders on OpenSource EWS buildbot should archive the built product and upload the archive to the server, so that the testers can download the archive and run the tests. This would also help in re-using the archives for various kind of testers (WK1, WK2 etc.), being more efficient and speed-up the overall system. For that, we should add DownloadBuiltProduct and ExtractBuiltProduct build steps.
Attachments
Proposed patch
(4.21 KB, patch)
2018-07-25 17:12 PDT
,
Aakash Jain
lforschler
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2018-07-25 17:12:00 PDT
Created
attachment 345804
[details]
Proposed patch Sample run:
http://ews-build.webkit-uat.org/#/builders/18/builds/26
Aakash Jain
Comment 2
2018-07-25 17:12:50 PDT
Comment on
attachment 345804
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=345804&action=review
> Tools/BuildSlaveSupport/ews-build/steps.py:29 > +EWS_URL = '
http://ews-build.webkit-uat.org/
'
Note that this URL would be updated later on when the server is deployed in production.
EWS Watchlist
Comment 3
2018-07-25 17:14:04 PDT
Comment hidden (obsolete)
Attachment 345804
[details]
did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:843: [TestExtractBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:843: [TestExtractBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:857: [TestExtractBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:857: [TestExtractBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Aakash Jain
Comment 4
2018-07-25 17:24:03 PDT
Committed
r234220
: <
https://trac.webkit.org/changeset/234220
>
Radar WebKit Bug Importer
Comment 5
2018-07-25 17:26:45 PDT
<
rdar://problem/42605103
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug