Bug 187978 - Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT
Summary: Turn assertion preventing removal of ActiveDOMObjects while we iterate over t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-24 16:33 PDT by Chris Dumez
Modified: 2018-07-25 09:14 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.29 KB, patch)
2018-07-24 16:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.91 MB, application/zip)
2018-07-24 20:43 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-07-24 16:33:51 PDT 
Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT. If code does this, this leads to hard to investigate crashes such as rdar://problem/42160890. With a release assertion, we would find the culprits right away.
The assertion guarding against addition of ActiveDOMObjects while we iterate is already a RELEASE_ASSERT.
Comment 1 Chris Dumez 2018-07-24 16:35:39 PDT 
Created attachment 345725 [details]
Patch
Comment 2 EWS Watchlist 2018-07-24 20:43:39 PDT 
Comment on attachment 345725 [details]
Patch

Attachment 345725 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8645595

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 3 EWS Watchlist 2018-07-24 20:43:51 PDT 
Created attachment 345743 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 WebKit Commit Bot 2018-07-25 09:12:50 PDT 
Comment on attachment 345725 [details]
Patch

Clearing flags on attachment: 345725

Committed r234197: <https://trac.webkit.org/changeset/234197>
Comment 5 WebKit Commit Bot 2018-07-25 09:12:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-25 09:14:18 PDT 
<rdar://problem/42585290>