RESOLVED FIXED 187978
Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT 
https://bugs.webkit.org/show_bug.cgi?id=187978
Summary Turn assertion preventing removal of ActiveDOMObjects while we iterate over t...
Chris Dumez
Reported 2018-07-24 16:33:51 PDT
Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT. If code does this, this leads to hard to investigate crashes such as rdar://problem/42160890. With a release assertion, we would find the culprits right away. The assertion guarding against addition of ActiveDOMObjects while we iterate is already a RELEASE_ASSERT.
Attachments
Patch (5.29 KB, patch)
2018-07-24 16:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.91 MB, application/zip)
2018-07-24 20:43 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-07-24 16:35:39 PDT
Created attachment 345725 [details] Patch
EWS Watchlist
Comment 2 2018-07-24 20:43:39 PDT
Comment on attachment 345725 [details] Patch Attachment 345725 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8645595 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 3 2018-07-24 20:43:51 PDT
Created attachment 345743 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 4 2018-07-25 09:12:50 PDT
Comment on attachment 345725 [details] Patch Clearing flags on attachment: 345725 Committed r234197: <https://trac.webkit.org/changeset/234197>
WebKit Commit Bot
Comment 5 2018-07-25 09:12:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-07-25 09:14:18 PDT
<rdar://problem/42585290>
Note You need to log in before you can comment on or make changes to this bug.