Bug 187976 - Mask AVBackgroundView to the corner radius.
Summary: Mask AVBackgroundView to the corner radius.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-24 15:36 PDT by Jeremy Jones
Modified: 2019-06-16 21:05 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2018-07-24 15:40 PDT, Jeremy Jones
jonlee: review+
jonlee: commit-queue-
Details | Formatted Diff | Diff
Patch for landing. (1.65 KB, patch)
2018-07-25 14:42 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-07-24 15:36:18 PDT
Mask AVBackgroundView to the corner radius.
Comment 1 Jeremy Jones 2018-07-24 15:37:17 PDT
rdar://problem/41810866
Comment 2 Jeremy Jones 2018-07-24 15:40:42 PDT
Created attachment 345721 [details]
Patch
Comment 3 Sam Weinig 2018-07-24 17:38:09 PDT
Comment on attachment 345721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review

> Source/WebKit/ChangeLog:12
> +        This changes sets the appropriate mask to the layer so the corners look correct.
> +
> +        * UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
> +        (-[WKFullscreenStackView init]):

How can this be tested?
Comment 4 Jon Lee 2018-07-24 20:46:42 PDT
Comment on attachment 345721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63
> +    [_backgroundView setClipsToBounds:YES];

Please add a FIXME for reverting this workaround.
Comment 5 Jeremy Jones 2018-07-25 14:38:31 PDT
(In reply to Jon Lee from comment #4)
> Comment on attachment 345721 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345721&action=review
> 
> > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63
> > +    [_backgroundView setClipsToBounds:YES];
> 
> Please add a FIXME for reverting this workaround.

Added bugzilla bug for the cleanup:
https://bugs.webkit.org/show_bug.cgi?id=188022
Comment 6 Jeremy Jones 2018-07-25 14:42:51 PDT
Created attachment 345785 [details]
Patch for landing.
Comment 7 Jeremy Jones 2018-07-25 14:43:36 PDT
(In reply to Sam Weinig from comment #3)
> Comment on attachment 345721 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345721&action=review
> 
> > Source/WebKit/ChangeLog:12
> > +        This changes sets the appropriate mask to the layer so the corners look correct.
> > +
> > +        * UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
> > +        (-[WKFullscreenStackView init]):
> 
> How can this be tested?

We don't have a way to test this.
Comment 8 WebKit Commit Bot 2018-07-25 15:51:30 PDT
Comment on attachment 345785 [details]
Patch for landing.

Clearing flags on attachment: 345785

Committed r234216: <https://trac.webkit.org/changeset/234216>
Comment 9 Frédéric Wang (:fredw) 2018-09-20 13:30:14 PDT
Comment on attachment 345785 [details]
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=345785&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:65
> +    [_backgroundView.get().layer setContinuousCorners:YES];

For the record, this is causing build failure with XCode 10 (public SDK). I opened https://bugs.webkit.org/show_bug.cgi?id=189786