Bug 187975 – Use CompletionHandler for policy decisions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Use CompletionHandler for policy decisions

[Alex Christensen]

Created attachment 345720 [details]
Patch

[EWS Watchlist]

Comment on attachment 345720 [details]
Patch

Attachment 345720 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8644755

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html

[EWS Watchlist]

Created attachment 345734 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Chris Dumez]

Comment on attachment 345720 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 345720 [details]
Patch

Clearing flags on attachment: 345720

Committed r234196: <https://trac.webkit.org/changeset/234196>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42585164>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 188011

[Alex Christensen]

Comment on attachment 345720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345720&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4121
> +        receivedPolicyDecision(policyAction, frame.get(), listenerID, nullptr, std::nullopt);

This nullptr should've been navigation.get()
:|

[Alex Christensen]

http://trac.webkit.org/r234210

[Alex Christensen]

Comment on attachment 345720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345720&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4022
> +                RunLoop::main().dispatch([this, protectedThis = makeRef(*this), navigation = makeRef(*navigation), proposedProcess = WTFMove(proposedProcess)]() mutable {

I changed this from makeRef(*this) to WTFMove(protectedThis) because of the ol' MSVC-inconsistently-thinks-this-means-containing-lambda bug

[Chris Dumez]

Comment on attachment 345720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345720&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4119
> +        ASSERT_UNUSED(policies, !policies);

I am frequently hitting this assertion when browsing in debug :( Could you please look into it?