String::formatWithArguments() in Source/WTF/wtf/text/WTFString.h is unused, let's remove it.
Created attachment 345659 [details] Patch
Created attachment 345668 [details] Patch
After doing this we should rename String::format to String::deprecatedFormat and start phasing it out. Clients can and should use string concatenation, clearly invokable as makeString or possibly just with the + operator, instead. More efficient, likely safer. A few clients might be using advanced features of printf, but even those could probably be added to the concatenation.
(In reply to Darin Adler from comment #3) > After doing this we should rename String::format to String::deprecatedFormat > and start phasing it out. Clients can and should use string concatenation, > clearly invokable as makeString or possibly just with the + operator, > instead. More efficient, likely safer. A few clients might be using advanced > features of printf, but even those could probably be added to the > concatenation. Thank you for the review Darin! I open bug 188191 for that.
Committed r234411: <https://trac.webkit.org/changeset/234411>
<rdar://problem/42765297>