Bug 187927 – CrashTracer: com.apple.WebKit.Storage at WebCore: WebCore::encodeKey

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

1   0x117b89069 WTFCrash
2   0x10ad51a6b WebCore::serializedTypeForKeyType(WebCore::IndexedDB::KeyType)
3   0x10ad35b73 WebCore::encodeKey(WTF::Vector<char, 0ul, WTF::CrashOnOverflow, 16ul>&, WebCore::IDBKeyData const&)
4   0x10ad35e08 WebCore::encodeKey(WTF::Vector<char, 0ul, WTF::CrashOnOverflow, 16ul>&, WebCore::IDBKeyData const&)
5   0x10ad35a60 WebCore::serializeIDBKeyData(WebCore::IDBKeyData const&)
6   0x10adb1316 WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord(long long, long long, WebCore::IDBKeyData const&, WebCore::IDBKeyData const&, long long)
7   0x10adb10ec WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey(WebCore::IDBIndexInfo const&, WebCore::IDBKeyData const&, WebCore::IndexKey const&, long long)
8   0x10adb4b36 WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord(WebCore::IDBObjectStoreInfo const&, WebCore::IDBKeyData const&, WebCore::ThreadSafeDataBuffer const&, long long)
9   0x10adb5872 WebCore::IDBServer::SQLiteIDBBackingStore::addRecord(WebCore::IDBResourceIdentifier const&, WebCore::IDBObjectStoreInfo const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&)
10  0x10adefcb0 WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd(unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode)
11  0x10ae204f4 void WTF::callMemberFunctionForCrossThreadTaskImpl<WebCore::IDBServer::UniqueIDBDatabase, void (WebCore::IDBServer::UniqueIDBDatabase::*)(unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode), std::__1::tuple<unsigned long long, WebCore::IDBResourceIdentifier, unsigned long long, WebCore::IDBKeyData, WebCore::IDBValue, WebCore::IndexedDB::ObjectStoreOverwriteMode>, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul>(WebCore::IDBServer::UniqueIDBDatabase*, void (WebCore::IDBServer::UniqueIDBDatabase::*)(unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode), std::__1::tuple<unsigned long long, WebCore::IDBResourceIdentifier, unsigned long long, WebCore::IDBKeyData, WebCore::IDBValue, WebCore::IndexedDB::ObjectStoreOverwriteMode>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul>)
12  0x10ae20320 void WTF::callMemberFunctionForCrossThreadTask<WebCore::IDBServer::UniqueIDBDatabase, void (WebCore::IDBServer::UniqueIDBDatabase::*)(unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode), std::__1::tuple<unsigned long long, WebCore::IDBResourceIdentifier, unsigned long long, WebCore::IDBKeyData, WebCore::IDBValue, WebCore::IndexedDB::ObjectStoreOverwriteMode>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul> >(WebCore::IDBServer::UniqueIDBDatabase*, void (WebCore::IDBServer::UniqueIDBDatabase::*)(unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode), std::__1::tuple<unsigned long long, WebCore::IDBResourceIdentifier, unsigned long long, WebCore::IDBKeyData, WebCore::IDBValue, WebCore::IndexedDB::ObjectStoreOverwriteMode>&&)
13  0x10ae202b4 WTF::CrossThreadTask WTF::createCrossThreadTask<WebCore::IDBServer::UniqueIDBDatabase, unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode, unsigned long long, WebCore::IDBResourceIdentifier, unsigned long long, WebCore::IDBKeyData, WebCore::IDBValue, WebCore::IndexedDB::ObjectStoreOverwriteMode>(WebCore::IDBServer::UniqueIDBDatabase&, void (WebCore::IDBServer::UniqueIDBDatabase::*)(unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode), unsigned long long const&, WebCore::IDBResourceIdentifier const&, unsigned long long const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode const&)::'lambda'()::operator()()
14  0x10ae20039 WTF::Function<void ()>::CallableWrapper<WTF::CrossThreadTask WTF::createCrossThreadTask<WebCore::IDBServer::UniqueIDBDatabase, unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode, unsigned long long, WebCore::IDBResourceIdentifier, unsigned long long, WebCore::IDBKeyData, WebCore::IDBValue, WebCore::IndexedDB::ObjectStoreOverwriteMode>(WebCore::IDBServer::UniqueIDBDatabase&, void (WebCore::IDBServer::UniqueIDBDatabase::*)(unsigned long long, WebCore::IDBResourceIdentifier const&, unsigned long long, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode), unsigned long long const&, WebCore::IDBResourceIdentifier const&, unsigned long long const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode const&)::'lambda'()>::call()
15  0x1098552cb WTF::Function<void ()>::operator()() const
16  0x10ad0c2a5 WTF::CrossThreadTask::performTask()
17  0x10adf99f2 WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask()

[Sihui Liu]

Created attachment 345611 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/42516426>

[Sihui Liu]

<rdar://problem/41629014>

[Sihui Liu]

(In reply to Sihui Liu from comment #3)
> <rdar://problem/41629014>

Wrong radar number, should be <rdar://problem/42388498>.

[Chris Dumez]

Comment on attachment 345611 [details]
Patch

Matches what is done in IDBKey::isValid(), r=me.

[EWS Watchlist]

Comment on attachment 345611 [details]
Patch

Attachment 345611 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8631444

New failing tests:
storage/indexeddb/index-multientry-private.html
imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.htm

[EWS Watchlist]

Created attachment 345619 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 345611 [details]
Patch

Attachment 345611 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8631529

New failing tests:
storage/indexeddb/index-multientry-private.html
imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.htm

[EWS Watchlist]

Created attachment 345622 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 345611 [details]
Patch

Attachment 345611 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8631515

New failing tests:
storage/indexeddb/index-multientry-private.html
imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.htm

[EWS Watchlist]

Created attachment 345623 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 345611 [details]
Patch

Attachment 345611 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8631524

New failing tests:
storage/indexeddb/index-multientry-private.html
imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.htm

[EWS Watchlist]

Created attachment 345624 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Sihui Liu]

(In reply to Build Bot from comment #12)
> Comment on attachment 345611 [details]
> Patch
> 
> Attachment 345611 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/8631524
> 
> New failing tests:
> storage/indexeddb/index-multientry-private.html
Updated test expectation as a new test case has been added in the js file it uses.

> imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.htm
Updated test expectation as a check becomes PASS after the patch.

[Sihui Liu]

Created attachment 345625 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 345625 [details]
Patch for landing

Clearing flags on attachment: 345625

Committed r234125: <https://trac.webkit.org/changeset/234125>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

Fixing radar linkage:

<rdar://problem/42388498>