RESOLVED FIXED 187925
Add test for fix in https://bugs.webkit.org/show_bug.cgi?id=187922 
https://bugs.webkit.org/show_bug.cgi?id=187925
Summary Add test for fix in https://bugs.webkit.org/show_bug.cgi?id=187922
Per Arne Vollan
Reported 2018-07-23 14:34:48 PDT
See comments in https://bugs.webkit.org/show_bug.cgi?id=187922 for how to test this.
Attachments
Patch (8.15 KB, patch)
2018-08-31 10:51 PDT, Per Arne Vollan 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (8.17 KB, patch)
2018-09-04 09:34 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-08-31 10:51:20 PDT
Created attachment 348651 [details] Patch
Per Arne Vollan
Comment 2 2018-08-31 13:24:22 PDT
Thanks for reviewing!
Per Arne Vollan
Comment 3 2018-09-04 09:34:23 PDT
Created attachment 348817 [details] Patch
Per Arne Vollan
Comment 4 2018-09-04 11:04:46 PDT
Committed r235619: <https://trac.webkit.org/changeset/235619/webkit>
Radar WebKit Bug Importer
Comment 5 2018-09-04 11:05:28 PDT
<rdar://problem/44103708>
Darin Adler
Comment 6 2018-09-08 18:38:53 PDT
Comment on attachment 348817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348817&action=review > Source/WebCore/testing/Internals.cpp:4724 > +unsigned long Internals::primaryScreenDisplayID() This should be "unsigned". IDL "unsigned long" corresponds to C++ "unsigned". > Source/WebCore/testing/Internals.h:738 > + unsigned long primaryScreenDisplayID(); "unsigned" > Source/WebCore/testing/Internals.idl:673 > + unsigned long primaryScreenDisplayID(); "unsigned"
Per Arne Vollan
Comment 7 2018-09-11 15:10:51 PDT
(In reply to Darin Adler from comment #6) > Comment on attachment 348817 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348817&action=review > > > Source/WebCore/testing/Internals.cpp:4724 > > +unsigned long Internals::primaryScreenDisplayID() > > This should be "unsigned". IDL "unsigned long" corresponds to C++ "unsigned". > > > Source/WebCore/testing/Internals.h:738 > > + unsigned long primaryScreenDisplayID(); > > "unsigned" > > > Source/WebCore/testing/Internals.idl:673 > > + unsigned long primaryScreenDisplayID(); > > "unsigned" Thanks! I'll change this.
Per Arne Vollan
Comment 8 2018-09-11 15:39:56 PDT
Committed r235916: <https://trac.webkit.org/changeset/235916/webkit>
Note You need to log in before you can comment on or make changes to this bug.