Bug 187921 – DisplayList::DrawRect() should take half of the border thickness into account when calculating the localBounds.

• Status: NEW
• Component: Layout and Rendering

[Said Abou-Hallawa]

This fixes some of the layout tests when enabling DisplayLists for paint phases.

[Said Abou-Hallawa]

Created attachment 345606 [details]
Patch

[Simon Fraser (smfr)]

These patches are impossible to review. I want to r- the templatization patch

[Said Abou-Hallawa]

Created attachment 345607 [details]
Patch for Review

[Said Abou-Hallawa]

(In reply to Simon Fraser (smfr) from comment #2)
> These patches are impossible to review. I want to r- the templatization patch

I have not asked for review yet for these patches (I mean getting r- or r+ for them). I will do that once I confirm we are getting a progression on MotionMark from this work, which should happen soon.

But you can add your comments you want in the patch named "Patch for Review". This patch has only the difference between the EWS patch of this bug and the EWS patch of the https://bugs.webkit.org/show_bug.cgi?id=187898.

I did not understand why you "want to r- the templatization patch" https://bugs.webkit.org/show_bug.cgi?id=187002. I think I answered all your concerns and the last patch succeeded to pass the compilation on all ports. So if you still have other concerns please add them there and I will be happy to answer them. Or I will change the approach if the current patch can't be changed to answer your concern.

[EWS Watchlist]

Comment on attachment 345606 [details]
Patch

Attachment 345606 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8631039

New failing tests:
displaylists/layer-dispay-list.html

[EWS Watchlist]

Created attachment 345615 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 345606 [details]
Patch

Attachment 345606 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8630947

New failing tests:
displaylists/layer-dispay-list.html

[EWS Watchlist]

Created attachment 345616 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 345606 [details]
Patch

Attachment 345606 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8631271

New failing tests:
displaylists/layer-dispay-list.html

[EWS Watchlist]

Created attachment 345620 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

Created attachment 345699 [details]
Patch

[EWS Watchlist]

Comment on attachment 345699 [details]
Patch

Attachment 345699 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8641270

New failing tests:
accessibility/smart-invert-reference.html

[EWS Watchlist]

Created attachment 345706 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

Created attachment 345708 [details]
Patch for Review

[Jon Lee]

(In reply to Said Abou-Hallawa from comment #4)
> (In reply to Simon Fraser (smfr) from comment #2)
> > These patches are impossible to review. I want to r- the templatization patch
> 
> I have not asked for review yet for these patches (I mean getting r- or r+
> for them). I will do that once I confirm we are getting a progression on
> MotionMark from this work, which should happen soon.
> 
It would be helpful if the patches were labeled as "Patch for EWS" or "WIP Patch".

[Radar WebKit Bug Importer]

<rdar://problem/42986543>