Bug 187900 - [GTK] 2.21.5 cannot be built from tarball
Summary: [GTK] 2.21.5 cannot be built from tarball
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-23 01:02 PDT by Tomas Popela
Modified: 2018-07-23 07:12 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2018-07-23 01:02:20 PDT 
Traceback (most recent call last):
  File "/builddir/build/BUILD/webkitgtk-2.21.5/Tools/gtk/generate-gtkdoc", line 31, in <module>
    import common
  File "/builddir/build/BUILD/webkitgtk-2.21.5/Tools/glib/common.py", line 28, in <module>
    from webkitpy.common.checkout.scm import Git
ImportError: No module named webkitpy.common.checkout.scm

The Tools/glib/common.py should be reworked/split to only call the webkitpy things when running from the checkout (I think that this is preferred) or webkitpy bits should be shipped as well in the tarball.
Comment 1 Tomas Popela 2018-07-23 01:04:41 PDT 
It's a regression after https://bugs.webkit.org/show_bug.cgi?id=185643 https://trac.webkit.org/changeset/233030
Comment 2 Michael Catanzaro 2018-07-23 07:12:18 PDT 
We had a successful build on GNOME infrastructure, but I think that's because we don't build gtkdoc.
Comment 3 Michael Catanzaro 2018-07-23 07:12:53 PDT 
Rolling out in bug #187904