Bug 18789 - WebView won't get closed with window in certain cases
: WebView won't get closed with window in certain cases
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit API
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Darin Adler
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-28 10:25 PDT by Darin Adler
Modified: 2008-05-05 09:37 PDT (History)
0 users

See Also:


Attachments
patch (4.12 KB, patch)
2008-04-28 10:26 PDT, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-04-28 10:25:54 PDT
By code inspection:

If the WebView is put into a window, then setHostWindow is called to make that same window the host window for the view, then the view is removed from the window, and then the window is closed, the WebView won't get closed.

If the WebView is put into a window, then setHostWIndow is called to make that same window the host window for a view, then setHostWindow is called to change the host window back to nil, and then the window is closed, the WebView won't get closed.
Comment 1 Darin Adler 2008-04-28 10:26:42 PDT
Created attachment 20870 [details]
patch
Comment 2 mitz@webkit.org 2008-04-28 10:33:56 PDT
Comment on attachment 20870 [details]
patch

r=me
Comment 3 Darin Adler 2008-05-05 09:37:42 PDT
r32874