Bug 187883 – Fix lldb summarizers for HashMaps and HashSets

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Fix lldb summarizers for HashMaps and HashSets

[Simon Fraser (smfr)]

Created attachment 345522 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 345527 [details]
Patch

[Daniel Bates]

Comment on attachment 345527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345527&action=review

r=me

> Tools/lldb/lldb_webkit_unittest.py:156
> +    def serial_test_WTFHashMap_tablesize_and_size(self):

Would it be meaningful to add tests for the empty hash table and empty hash set?

[Simon Fraser (smfr)]

(In reply to Daniel Bates from comment #3)
> Comment on attachment 345527 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345527&action=review
> 
> r=me
> 
> > Tools/lldb/lldb_webkit_unittest.py:156
> > +    def serial_test_WTFHashMap_tablesize_and_size(self):
> 
> Would it be meaningful to add tests for the empty hash table and empty hash
> set?

I don't think so, really.

[WebKit Commit Bot]

Comment on attachment 345527 [details]
Patch

Rejecting attachment 345527 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 345527, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=345527&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=187883&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 345527 from bug 187883.
Fetching: https://bugs.webkit.org/attachment.cgi?id=345527
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Daniel Bates']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/lldb/lldbWebKitTester/main.cpp
patching file Tools/lldb/lldb_webkit.py
Hunk #1 FAILED at 39.
Hunk #2 succeeded at 97 (offset 12 lines).
Hunk #3 succeeded at 573 (offset 151 lines).
Hunk #4 succeeded at 617 (offset 151 lines).
Hunk #5 succeeded at 689 (offset 151 lines).
1 out of 5 hunks FAILED -- saving rejects to file Tools/lldb/lldb_webkit.py.rej
patching file Tools/lldb/lldb_webkit_unittest.py

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Daniel Bates']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/lldb/lldbWebKitTester/main.cpp
patching file Tools/lldb/lldb_webkit.py
Hunk #1 FAILED at 39.
Hunk #2 succeeded at 97 (offset 12 lines).
Hunk #3 succeeded at 573 (offset 151 lines).
Hunk #4 succeeded at 617 (offset 151 lines).
Hunk #5 succeeded at 689 (offset 151 lines).
1 out of 5 hunks FAILED -- saving rejects to file Tools/lldb/lldb_webkit.py.rej
patching file Tools/lldb/lldb_webkit_unittest.py

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Daniel Bates']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   ed2da807d3c..dc73ddb5e0d  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 234086 = ed2da807d3cf4b5706430e3c192e1df33836c93c
r234087 = dc73ddb5e0da679c1452249ea1c0ddf783ad0827
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/8613595

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/234088/webkit

[Radar WebKit Bug Importer]

<rdar://problem/42473235>

[Simon Fraser (smfr)]

*** Bug 187783 has been marked as a duplicate of this bug. ***