Bug 187876 - REGRESSION(r233925): Can't go into PiP twice
Summary: REGRESSION(r233925): Can't go into PiP twice
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-20 17:08 PDT by Jer Noble
Modified: 2018-09-07 10:36 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2018-07-20 17:12 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-07-20 17:08:07 PDT 
REGRESSION(r233925): Can't go into PiP twice
Comment 1 Jer Noble 2018-07-20 17:11:33 PDT 
<rdar://problem/42444520>
Comment 2 Jer Noble 2018-07-20 17:12:25 PDT 
Created attachment 345492 [details]
Patch
Comment 3 Jeremy Jones 2018-07-20 17:24:08 PDT 
Comment on attachment 345492 [details]
Patch

provisional r=me
In this case the clientCount is unexpectedly not dropping to zero. There should be a bug filed about that too.
Comment 4 WebKit Commit Bot 2018-07-20 20:50:53 PDT 
Comment on attachment 345492 [details]
Patch

Clearing flags on attachment: 345492

Committed r234081: <https://trac.webkit.org/changeset/234081>
Comment 5 WebKit Commit Bot 2018-07-20 20:50:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Dawei Fenton (:realdawei) 2018-08-06 16:23:16 PDT 
After this revision The bots (High Sierra WK2 Debug) have been seeing flaky timeouts on
 TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction

output from latest run:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/4382/steps/run-api-tests/logs/stdio
Comment 7 Ryan Haddad 2018-09-07 10:11:30 PDT 
(In reply to Dawei Fenton (:realdawei) from comment #6)
> After this revision The bots (High Sierra WK2 Debug) have been seeing flaky
> timeouts on
>  TestWebKitAPI.VideoControlsManager.
> VideoControlsManagerAudioElementFollowingUserInteraction

This is still happening. Dawei, please file a bug.
Comment 8 Dawei Fenton (:realdawei) 2018-09-07 10:36:44 PDT 
(In reply to Ryan Haddad from comment #7)
> (In reply to Dawei Fenton (:realdawei) from comment #6)
> > After this revision The bots (High Sierra WK2 Debug) have been seeing flaky
> > timeouts on
> >  TestWebKitAPI.VideoControlsManager.
> > VideoControlsManagerAudioElementFollowingUserInteraction
> 
> This is still happening. Dawei, please file a bug.


tracking it here: https://bugs.webkit.org/show_bug.cgi?id=187972