Bug 187875 - [LFC] Do not use virtual methods to construct floating/formatting states.
Summary: [LFC] Do not use virtual methods to construct floating/formatting states.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-20 16:57 PDT by zalan
Modified: 2018-07-21 11:49 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.78 KB, patch)
2018-07-20 18:42 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.79 KB, patch)
2018-07-20 18:48 PDT, zalan 		koivisto: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.93 MB, application/zip)
2018-07-20 22:37 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-07-20 16:57:53 PDT 
it just makes the code more complicated.
Comment 1 zalan 2018-07-20 18:42:11 PDT 
Created attachment 345496 [details]
Patch
Comment 2 zalan 2018-07-20 18:48:09 PDT 
Created attachment 345497 [details]
Patch
Comment 3 EWS Watchlist 2018-07-20 22:37:03 PDT 
Comment on attachment 345497 [details]
Patch

Attachment 345497 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8606179

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 4 EWS Watchlist 2018-07-20 22:37:14 PDT 
Created attachment 345506 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 zalan 2018-07-21 11:47:08 PDT 
Committed r234084: <https://trac.webkit.org/changeset/234084>
Comment 6 Radar WebKit Bug Importer 2018-07-21 11:49:11 PDT 
<rdar://problem/42467000>