Bug 187873 - REGRESSION (r233974): Cannot close pip'd video; pops back into PiP.
Summary: REGRESSION (r233974): Cannot close pip'd video; pops back into PiP.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-20 15:53 PDT by Jer Noble
Modified: 2018-07-20 17:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2018-07-20 15:56 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-07-20 15:53:24 PDT 
REGRESSION (r233974): Cannot close pip'd video; pops back into PiP.
Comment 1 Jer Noble 2018-07-20 15:54:00 PDT 
<rdar://problem/42442528>
Comment 2 Jer Noble 2018-07-20 15:56:32 PDT 
Created attachment 345485 [details]
Patch
Comment 3 Jon Lee 2018-07-20 16:31:03 PDT 
Comment on attachment 345485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345485&action=review

> Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:-338
> -    // FIXME 25096170: Should animate only if the page with the video is unobscured. For now, always close without animation.

If this comment is going away, are we closing the associated also?
Comment 4 Jer Noble 2018-07-20 17:13:34 PDT 
(In reply to Jon Lee from comment #3)
> Comment on attachment 345485 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345485&action=review
> 
> > Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:-338
> > -    // FIXME 25096170: Should animate only if the page with the video is unobscured. For now, always close without animation.
> 
> If this comment is going away, are we closing the associated also?

That comment was never right; this method only gets called when the "stop" button is clicked, so there is no animation.
Comment 5 WebKit Commit Bot 2018-07-20 17:42:27 PDT 
Comment on attachment 345485 [details]
Patch

Clearing flags on attachment: 345485

Committed r234078: <https://trac.webkit.org/changeset/234078>
Comment 6 WebKit Commit Bot 2018-07-20 17:42:29 PDT 
All reviewed patches have been landed.  Closing bug.