Bug 187868 - [WinCairo] Add implementation for setting cursors
Summary: [WinCairo] Add implementation for setting cursors
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-07-20 11:16 PDT by Stephan Szabo
Modified: 2018-07-23 18:36 PDT (History)
6 users (show)

See Also:

Patch (1.67 KB, patch)
2018-07-20 11:20 PDT, Stephan Szabo
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.20 MB, application/zip)
2018-07-20 12:41 PDT, EWS Watchlist
no flags Details
Patch reupload (1.67 KB, patch)
2018-07-20 13:14 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2018-07-23 13:48 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-07-20 11:16:33 PDT
[WinCairo] Add implementation for setting cursors
Comment 1 Stephan Szabo 2018-07-20 11:20:14 PDT
Created attachment 345465 [details]
Comment 2 EWS Watchlist 2018-07-20 12:41:46 PDT
Comment on attachment 345465 [details]

Attachment 345465 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8601823

New failing tests:
Comment 3 EWS Watchlist 2018-07-20 12:41:48 PDT
Created attachment 345474 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 Stephan Szabo 2018-07-20 13:14:07 PDT
Created attachment 345477 [details]
Patch reupload
Comment 5 Fujii Hironori 2018-07-22 20:48:00 PDT
The original implementation handle WM_SETCURSOR. Do you need to do it?
Comment 6 Stephan Szabo 2018-07-23 13:48:43 PDT
Created attachment 345603 [details]

The WM_SETCURSOR stuff was already in WebView, so tied back into that path from the page client implementation.
Comment 7 WebKit Commit Bot 2018-07-23 18:35:54 PDT
Comment on attachment 345603 [details]

Clearing flags on attachment: 345603

Committed r234129: <https://trac.webkit.org/changeset/234129>
Comment 8 WebKit Commit Bot 2018-07-23 18:35:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-07-23 18:36:22 PDT