Bug 187862 - [WinCairo] Fix detection of held modifier keys for key events
Summary: [WinCairo] Fix detection of held modifier keys for key events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-20 10:29 PDT by Stephan Szabo
Modified: 2018-07-23 10:54 PDT (History)
5 users (show)

See Also:

Attachments
Use requested key in IsKeyInDownState (1.17 KB, patch)
2018-07-20 10:47 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (13.04 MB, application/zip)
2018-07-21 02:24 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-07-20 10:29:28 PDT 
[WinCairo] Fix detection of held modifier keys for key events
Comment 1 Stephan Szabo 2018-07-20 10:47:22 PDT 
We were always checking VK_MENU when checking if IsKeyInDownState rather than the requested modifier.
Comment 2 Stephan Szabo 2018-07-20 10:47:55 PDT 
Created attachment 345460 [details]
Use requested key in IsKeyInDownState
Comment 3 EWS Watchlist 2018-07-21 02:24:01 PDT 
Comment on attachment 345460 [details]
Use requested key in IsKeyInDownState

Attachment 345460 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8607279

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 4 EWS Watchlist 2018-07-21 02:24:12 PDT 
Created attachment 345508 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Stephan Szabo 2018-07-23 10:25:53 PDT 
Win bot appears to be failing both with and without the patch with similar results.
Comment 6 WebKit Commit Bot 2018-07-23 10:52:39 PDT 
Comment on attachment 345460 [details]
Use requested key in IsKeyInDownState

Clearing flags on attachment: 345460

Committed r234103: <https://trac.webkit.org/changeset/234103>
Comment 7 WebKit Commit Bot 2018-07-23 10:52:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-23 10:54:11 PDT 
<rdar://problem/42506025>