Bug 187854 - FrameView::paintContents should release log when the render tree is dirty.
Summary: FrameView::paintContents should release log when the render tree is dirty.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-20 08:38 PDT by zalan
Modified: 2018-07-20 10:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2018-07-20 09:43 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2018-07-20 10:09 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-07-20 08:38:28 PDT 
ssia
Comment 1 Radar WebKit Bug Importer 2018-07-20 09:37:01 PDT 
<rdar://problem/42432371>
Comment 2 zalan 2018-07-20 09:43:22 PDT 
Created attachment 345451 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-07-20 10:03:58 PDT 
Comment on attachment 345451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345451&action=review

> Source/WebCore/page/FrameView.cpp:4146
> +        RELEASE_LOG_IF_ALLOWED("painting: Render tree needs layout. Can't paint at this time -is mainframe(%d)", frame().isMainFrame());

Let's put "FrameView::paintContents" in the log message somewhere. Maybe "FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)".
Comment 4 zalan 2018-07-20 10:09:39 PDT 
Created attachment 345455 [details]
Patch
Comment 5 WebKit Commit Bot 2018-07-20 10:37:04 PDT 
Comment on attachment 345455 [details]
Patch

Clearing flags on attachment: 345455

Committed r234053: <https://trac.webkit.org/changeset/234053>
Comment 6 WebKit Commit Bot 2018-07-20 10:37:05 PDT 
All reviewed patches have been landed.  Closing bug.