RESOLVED FIXED 187852
[JSC] A bit performance improvement for Object.assign by cleaning up code 
https://bugs.webkit.org/show_bug.cgi?id=187852
Summary [JSC] A bit performance improvement for Object.assign by cleaning up code
Yusuke Suzuki
Reported 2018-07-20 03:06:38 PDT
[JSC] A bit performance improvement for Object.assign by cleaning up code
Attachments
Patch (8.00 KB, patch)
2018-07-20 03:09 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-20 03:09:17 PDT
Created attachment 345438 [details] Patch
Saam Barati
Comment 2 2018-07-20 10:57:48 PDT
Comment on attachment 345438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345438&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + 2. canDoFastPath is not necessary. Restructuring the code to clean up things. I agree this is a bit ugly, but the reason I wrote it that way so was we don't try to use the Structure* after the source could have potentially transitioned. I would vote for just loading the structure twice instead of keeping a variable around that points to something that may no longer be source's structure. (LLVM should CSE the structure load anyways)
Yusuke Suzuki
Comment 3 2018-07-20 11:28:33 PDT
Committed r234058: <https://trac.webkit.org/changeset/234058>
Radar WebKit Bug Importer
Comment 4 2018-07-20 11:29:21 PDT
<rdar://problem/42437911>
Note You need to log in before you can comment on or make changes to this bug.