Bug 187852 - [JSC] A bit performance improvement for Object.assign by cleaning up code
Summary: [JSC] A bit performance improvement for Object.assign by cleaning up code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-20 03:06 PDT by Yusuke Suzuki
Modified: 2018-07-20 11:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.00 KB, patch)
2018-07-20 03:09 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-20 03:06:38 PDT 
[JSC] A bit performance improvement for Object.assign by cleaning up code
Comment 1 Yusuke Suzuki 2018-07-20 03:09:17 PDT 
Created attachment 345438 [details]
Patch
Comment 2 Saam Barati 2018-07-20 10:57:48 PDT 
Comment on attachment 345438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345438&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +        2. canDoFastPath is not necessary. Restructuring the code to clean up things.

I agree this is a bit ugly, but the reason I wrote it that way so was we don't try to use the Structure* after the source could have potentially transitioned.

I would vote for just loading the structure twice instead of keeping a variable around that points to something that may no longer be source's structure. (LLVM should CSE the structure load anyways)
Comment 3 Yusuke Suzuki 2018-07-20 11:28:33 PDT 
Committed r234058: <https://trac.webkit.org/changeset/234058>
Comment 4 Radar WebKit Bug Importer 2018-07-20 11:29:21 PDT 
<rdar://problem/42437911>