Bug 187847 - [GTK][WPE] enable-media-capabilities websetting
Summary: [GTK][WPE] enable-media-capabilities websetting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-20 01:29 PDT by Philippe Normand
Modified: 2018-07-20 06:23 PDT (History)
7 users (show)

See Also:


Attachments
Patch (9.92 KB, patch)
2018-07-20 01:33 PDT, Philippe Normand
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-07-20 01:29:07 PDT
This spec is not fully implemented yet but a runtime setting is needed, regardless.
Comment 1 Philippe Normand 2018-07-20 01:33:15 PDT
Created attachment 345435 [details]
Patch
Comment 2 EWS Watchlist 2018-07-20 01:34:21 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Adrian Perez 2018-07-20 01:41:46 PDT
Comment on attachment 345435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345435&action=review

(Informal) r+ with a nit

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1336
> +     * but also output capabilities to find the best match based on the deviceâs

Please change the “â” to an apostrophe here... Or is this Bugzilla
not showing UTF-8 or some other encoding correctly?
Comment 4 Philippe Normand 2018-07-20 01:44:50 PDT
Comment on attachment 345435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345435&action=review

>> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1336
>> +     * but also output capabilities to find the best match based on the deviceâs
> 
> Please change the “â” to an apostrophe here... Or is this Bugzilla
> not showing UTF-8 or some other encoding correctly?

It's a bugzilla bug. I simply verbatim-copied the spec abstract :)
Comment 5 Philippe Normand 2018-07-20 02:00:38 PDT
Committed r234038: <https://trac.webkit.org/changeset/234038>
Comment 6 Michael Catanzaro 2018-07-20 06:14:37 PDT
I believe we agreed not to expose new WebKitSettings in the API until the associated feature is largely implemented.

Why is a setting needed? This is something that we will want to be off by default (unavailable in Epiphany)? I doubt any applications will know or want to turn it off if it is on by default? I have to trust your judgment here, because I don't know anything about the feature... I just want to make sure it makes sense to add the API. And avoid the situation where we have enable-mediasource and enable-media-stream that have done nothing for the first five years.
Comment 7 Philippe Normand 2018-07-20 06:23:15 PDT
If you read the patch you'll see it's off by default.