Bug 187844 - Remove completed animations from GraphicsLayer, thus avoiding excessive backing store allocation
Summary: Remove completed animations from GraphicsLayer, thus avoiding excessive backi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-19 19:59 PDT by Simon Fraser (smfr)
Modified: 2018-07-20 16:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.54 KB, patch)
2018-07-19 20:06 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (12.59 KB, patch)
2018-07-19 20:25 PDT, Simon Fraser (smfr) 		dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.25 MB, application/zip)
2018-07-19 22:18 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-07-19 19:59:07 PDT 
Remove completed animations from GraphicsLayer, thus avoiding excessive backing store allocation
Comment 1 Simon Fraser (smfr) 2018-07-19 20:06:01 PDT 
Created attachment 345421 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-07-19 20:06:33 PDT 
rdar://problem/40387294
Comment 3 Simon Fraser (smfr) 2018-07-19 20:25:16 PDT 
Created attachment 345422 [details]
Patch
Comment 4 EWS Watchlist 2018-07-19 22:18:26 PDT 
Comment on attachment 345422 [details]
Patch

Attachment 345422 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8595479

New failing tests:
compositing/backing/backing-store-attachment-fill-forwards-animation.html
Comment 5 EWS Watchlist 2018-07-19 22:18:27 PDT 
Created attachment 345427 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 Dean Jackson 2018-07-20 10:03:54 PDT 
Comment on attachment 345422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345422&action=review

> Source/WebCore/page/animation/KeyframeAnimation.cpp:300
> +void KeyframeAnimation::endAnimation(bool fillingForwards)

You say fillForwards in other places.
Comment 7 Simon Fraser (smfr) 2018-07-20 16:34:15 PDT 
https://trac.webkit.org/changeset/234073/webkit