Bug 187830 - Reduce getters/setters in WebFramePolicyListenerProxy
Summary: Reduce getters/setters in WebFramePolicyListenerProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-19 17:07 PDT by Alex Christensen
Modified: 2018-07-24 10:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.96 KB, patch)
2018-07-19 17:11 PDT, Alex Christensen 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-07-19 17:07:56 PDT 
Reduce getters/setters in WebFramePolicyListenerProxy
Comment 1 Alex Christensen 2018-07-19 17:11:14 PDT 
Created attachment 345404 [details]
Patch
Comment 2 Dean Jackson 2018-07-23 16:00:30 PDT 
Comment on attachment 345404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345404&action=review

> Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:54
> +enum class ShouldProcessSwapIfPossible { No, Yes };

Shouldn't this be ShouldProcessSwap { DoNotProcess, ProcessIfPossible } ?
Comment 3 Chris Dumez 2018-07-23 16:03:59 PDT 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 345404 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345404&action=review
> 
> > Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:54
> > +enum class ShouldProcessSwapIfPossible { No, Yes };
> 
> Shouldn't this be ShouldProcessSwap { DoNotProcess, ProcessIfPossible } ?

DoNotProcess / ProcessIfPossible do not make sense. This is not about processing about about process swapping.
Comment 4 Alex Christensen 2018-07-24 10:27:28 PDT 
http://trac.webkit.org/r234154
Comment 5 Radar WebKit Bug Importer 2018-07-24 10:28:24 PDT 
<rdar://problem/42546369>