Upcoming patch should fix a bunch of warnings we have when compiling on 32-bit platforms (some of them are x86-specific).
Created attachment 345348 [details] Patch The patch fixing these pesky warnings.
Comment on attachment 345348 [details] Patch r- because this broke the Mac 32-bit build.
(In reply to Mark Lam from comment #2) > Comment on attachment 345348 [details] > Patch > > r- because this broke the Mac 32-bit build. Could you share a build log?
(In reply to Guillaume Emont from comment #3) > (In reply to Mark Lam from comment #2) > > Comment on attachment 345348 [details] > > Patch > > > > r- because this broke the Mac 32-bit build. > > Could you share a build log? It's right there in the red EWS bubble above: https://webkit-queues.webkit.org/results/8586996 In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource6.cpp:2: ./assembler/MacroAssemblerPrinter.cpp:92:37: error: format specifies type 'int' but the argument has type 'long' [-Werror,-Wformat] out.printf("pc:<%p %d>", value, bitwise_cast<intptr_t>(value)); ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ %ld ./assembler/MacroAssemblerPrinter.cpp:104:64: error: format specifies type 'int' but the argument has type 'intptr_t' (aka 'long') [-Werror,-Wformat] out.printf("%s:<%p %d>", name, bitwise_cast<void*>(value), value); ~~ ^~~~~ %ld ./assembler/MacroAssemblerPrinter.cpp:125:95: error: format specifies type 'int' but the argument has type 'intptr_t' (aka 'long') [-Werror,-Wformat] out.printf("Address{base:%s:<%p %d>, offset:<0x%x %d>", name, bitwise_cast<void*>(value), value, address.offset, address.offset); ~~ ^~~~~ %ld 3 errors generated.
(In reply to Mark Lam from comment #4) > (In reply to Guillaume Emont from comment #3) > > (In reply to Mark Lam from comment #2) > > > Comment on attachment 345348 [details] > > > Patch > > > > > > r- because this broke the Mac 32-bit build. > > > > Could you share a build log? > > It's right there in the red EWS bubble above: > https://webkit-queues.webkit.org/results/8586996 > > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/ > unified-sources/UnifiedSource6.cpp:2: > ./assembler/MacroAssemblerPrinter.cpp:92:37: error: format specifies type > 'int' but the argument has type 'long' [-Werror,-Wformat] > out.printf("pc:<%p %d>", value, bitwise_cast<intptr_t>(value)); > ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > %ld > ./assembler/MacroAssemblerPrinter.cpp:104:64: error: format specifies type > 'int' but the argument has type 'intptr_t' (aka 'long') [-Werror,-Wformat] > out.printf("%s:<%p %d>", name, bitwise_cast<void*>(value), value); > ~~ ^~~~~ > %ld > ./assembler/MacroAssemblerPrinter.cpp:125:95: error: format specifies type > 'int' but the argument has type 'intptr_t' (aka 'long') [-Werror,-Wformat] > out.printf("Address{base:%s:<%p %d>, offset:<0x%x %d>", name, > bitwise_cast<void*>(value), value, address.offset, address.offset); > ~~ > ^~~~~ > %ld > 3 errors generated. Oops, sorry, for some reason some EWS bubbles did not appear for me yesterday, got it now, thanks!
Created attachment 345439 [details] Patch New version of the patch using PRIdPTR -- smaller change and should work on mac 32
Comment on attachment 345439 [details] Patch Attachment 345439 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8604941 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
Created attachment 345498 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Ping reviewer. I think the win bot errors are issues with the bot and not the patch.
Comment on attachment 345439 [details] Patch r=me
Comment on attachment 345439 [details] Patch Clearing flags on attachment: 345439 Committed r234426: <https://trac.webkit.org/changeset/234426>
All reviewed patches have been landed. Closing bug.
<rdar://problem/42773728>