Bug 187798 - [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
Summary: [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-07-19 04:54 PDT by Carlos Garcia Campos
Modified: 2018-07-19 23:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (40.32 KB, patch)
2018-07-19 05:01 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-07-19 04:54:28 PDT 
Because a JSCClass is pretty much useless without an instance in this case. It should be similar to jsc_value_new_object() because indeed we are creating a new object. This makes destroy function and vtable functions to work.
Comment 1 Carlos Garcia Campos 2018-07-19 05:01:19 PDT 
Created attachment 345342 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-07-19 23:11:55 PDT 
Committed r234025: <https://trac.webkit.org/changeset/234025>
Comment 3 Radar WebKit Bug Importer 2018-07-19 23:12:17 PDT 
<rdar://problem/42416631>