Bug 187787 - Better deal with unexpected descriptor types in IPC::Connection's createMessageDecoder()
Summary: Better deal with unexpected descriptor types in IPC::Connection's createMessa...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-18 15:24 PDT by Chris Dumez
Modified: 2018-07-18 15:57 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2018-07-18 15:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-07-18 15:24:07 PDT
Better deal with unexpected descriptor types in IPC::Connection's createMessageDecoder() so that decoding actually fails instead of adding default-constructed IPC::Attachment objects to the Decoder.
We have cases where decoding succeeds but the mach_port passed via IPC is null (rdar://problem/41995022) and this could be the cause.
Comment 1 Chris Dumez 2018-07-18 15:25:23 PDT
Created attachment 345294 [details]
Patch