Bug 187786 - [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
Summary: [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-18 15:15 PDT by Stephan Szabo
Modified: 2018-07-19 16:14 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2018-07-18 15:19 PDT, Stephan Szabo 		Hironori.Fujii: review-
Details | Formatted Diff | Diff
Support DEVELOPER_MODE for allowing inspection of web inspector (2.23 KB, patch)
2018-07-19 11:51 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-07-18 15:15:26 PDT 
[WinCairo] Add missing piece for inspecting web inspector
Comment 1 Stephan Szabo 2018-07-18 15:19:04 PDT 
Created attachment 345292 [details]
Patch
Comment 2 Stephan Szabo 2018-07-18 15:22:32 PDT 
We had added the support for setting the flags behind ENABLE(DEVELOPER_MODE) ala GTK to make the inspector page have DeveloperExtrasEnabled, but not the bits in cmake/scripts to get the flag set from the build.
Comment 4 Fujii Hironori 2018-07-18 19:35:49 PDT 
Comment on attachment 345292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345292&action=review

> Source/cmake/OptionsWin.cmake:96
> +SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE})

I think you should define it in OptionsWinCairo.cmake to keep AppleWin port untouched.

> Tools/ChangeLog:3
> +        [WinCairo] Add missing piece for inspecting web inspector

What is the missing piece? I like more informative summary.

> ChangeLog:8
> +        * Source/cmake/OptionsWin.cmake:

This change needs a more informative change log entry.
Comment 5 Stephan Szabo 2018-07-19 11:51:32 PDT 
Created attachment 345370 [details]
Support DEVELOPER_MODE for allowing inspection of web inspector
Comment 6 WebKit Commit Bot 2018-07-19 16:11:34 PDT 
Comment on attachment 345370 [details]
Support DEVELOPER_MODE for allowing inspection of web inspector

Clearing flags on attachment: 345370

Committed r234010: <https://trac.webkit.org/changeset/234010>
Comment 7 WebKit Commit Bot 2018-07-19 16:11:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-19 16:14:01 PDT 
<rdar://problem/42405082>