Bug 187786 – [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Stephan Szabo]

[WinCairo] Add missing piece for inspecting web inspector

[Stephan Szabo]

Created attachment 345292 [details]
Patch

[Stephan Szabo]

We had added the support for setting the flags behind ENABLE(DEVELOPER_MODE) ala GTK to make the inspector page have DeveloperExtrasEnabled, but not the bits in cmake/scripts to get the flag set from the build.

[Fujii Hironori]

https://github.com/WebKit/webkit/blob/2f9002c4c64ab5eb4670dd7043f23a0b3e96fec0/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp#L194

[Fujii Hironori]

Comment on attachment 345292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345292&action=review

> Source/cmake/OptionsWin.cmake:96
> +SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE})

I think you should define it in OptionsWinCairo.cmake to keep AppleWin port untouched.

> Tools/ChangeLog:3
> +        [WinCairo] Add missing piece for inspecting web inspector

What is the missing piece? I like more informative summary.

> ChangeLog:8
> +        * Source/cmake/OptionsWin.cmake:

This change needs a more informative change log entry.

[Stephan Szabo]

Created attachment 345370 [details]
Support DEVELOPER_MODE for allowing inspection of web inspector

[WebKit Commit Bot]

Comment on attachment 345370 [details]
Support DEVELOPER_MODE for allowing inspection of web inspector

Clearing flags on attachment: 345370

Committed r234010: <https://trac.webkit.org/changeset/234010>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42405082>