REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9: 50 WebKit: WKBooleanGetValue <== 50 WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::shouldProcessWorkQueue() const 50 WebKitTestRunnerInjectedBundle: WTR::InjectedBundlePage::frameDidChangeLocation(OpaqueWKBundleFrame const*) 50 WebKit: WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame(WebKit::WebPage&, WebKit::WebFrame&, WTF::RefPtr<API::Object, WTF::DumbPtrTraits<API::Object> >&) 50 WebKit: WebKit::WebFrameLoaderClient::dispatchDidFinishLoad() 50 WebCore: WebCore::FrameLoader::checkLoadCompleteForThisFrame() 50 WebCore: WebCore::FrameLoader::checkLoadComplete() 50 WebCore: WebCore::DocumentLoader::finishedLoading() 50 WebCore: WebCore::DocumentLoader::maybeLoadEmpty() 50 WebCore: WebCore::DocumentLoader::startLoadingMainResource(WebCore::ShouldContinue) 50 WebCore: WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::ShouldContinue, WebCore::AllowNavigationToInvalidURL)::$_14::operator()() const 50 WebCore: WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::ShouldContinue, WebCore::AllowNavigationToInvalidURL) 50 WebCore: WTF::Function<void (WebCore::ResourceRequest&&, WTF::WeakPtr<WebCore::FormState>&&, WebCore::ShouldContinue)>::CallableWrapper<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::RefPtr<WebCore::FormState, WTF::DumbPtrTraits<WebCore::FormState> >&&, WebCore::AllowNavigationToInvalidURL, WebCore::ShouldTreatAsContinuingLoad, WTF::CompletionHandler<void ()>&&)::$_9>::call(WebCore::ResourceRequest&&, WTF::WeakPtr<WebCore::FormState>&&, WebCore::ShouldContinue) 50 WebCore: WTF::Function<void (WebCore::PolicyAction)>::CallableWrapper<WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest&&, WebCore::ResourceResponse const&, WebCore::DocumentLoader*, WTF::RefPtr<WebCore::FormState, WTF::DumbPtrTraits<WebCore::FormState> >&&, WTF::CompletionHandler<void (WebCore::ResourceRequest&&, WTF::WeakPtr<WebCore::FormState>&&, WebCore::ShouldContinue)>&&, WebCore::PolicyDecisionMode)::$_2>::call(WebCore::PolicyAction) 50 WebKit: WebKit::WebFrame::didReceivePolicyDecision(unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID, std::optional<WebKit::WebsitePoliciesData>&&) 50 WebKit: WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) 50 WebKit: IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 50 WebKit: WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 50 WebKit: IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 50 WebKit: IPC::Connection::dispatchOneIncomingMessage() 50 JavaScriptCore: WTF::RunLoop::performWork() 50 JavaScriptCore: WTF::RunLoop::performWork(void*) 50 CoreFoundation: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 50 CoreFoundation: __CFRunLoopDoSource0 50 CoreFoundation: __CFRunLoopDoSources0 50 CoreFoundation: __CFRunLoopRun 50 CoreFoundation: CFRunLoopRunSpecific 50 Foundation: -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 50 Foundation: -[NSRunLoop(NSRunLoop) run] 50 libxpc.dylib: _xpc_objc_main 50 libxpc.dylib: xpc_main 50 com.apple.WebKit.WebContent.Development: 50 libdyld.dylib: start
<rdar://problem/42329230>
Created attachment 345290 [details] Patch
Comment on attachment 345290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345290&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself When process *swaps* on navigation?
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 345290 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > When process *swaps* on navigation? "when process swapping on navigation" reads well to me, let's ask an American :) Brady?
(In reply to Chris Dumez from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 345290 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > > > When process *swaps* on navigation? > > "when process swapping on navigation" reads well to me, let's ask an > American :) Brady? "process swapping" being a noun we've invented makes it read okay. I'd rewrite: "This happens when swapping processes on navigation..."
(In reply to Brady Eidson from comment #5) > (In reply to Chris Dumez from comment #4) > > (In reply to Ryosuke Niwa from comment #3) > > > Comment on attachment 345290 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > > > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > > > > > When process *swaps* on navigation? > > > > "when process swapping on navigation" reads well to me, let's ask an > > American :) Brady? > > "process swapping" being a noun we've invented makes it read okay. Both a noun and a verb, but regardless it requires you to be familiar with it. My proposed rewrite doesn't: > > I'd rewrite: "This happens when swapping processes on navigation..."
Committed r233941: <https://trac.webkit.org/changeset/233941>